From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 11A721FF13E for ; Fri, 06 Feb 2026 17:34:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F2C91B456; Fri, 6 Feb 2026 17:35:31 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 0/2] fix: cli: bash completions not working for CLI tools Date: Fri, 6 Feb 2026 17:35:17 +0100 Message-ID: <20260206163519.218579-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770395649144 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AYWGQLRWPLCIYPEEPLYSHAGZGK3VK45U X-Message-ID-Hash: AYWGQLRWPLCIYPEEPLYSHAGZGK3VK45U X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Shell completions for the CLIs were not working because the completion files were installed with the `.bc` extension. According to the bash-completion documentation [1], completion files should either use the `.bash` extension or no extension at all. Debian currently ships bash-completion 2.16 [2]. Since installing files without an extension is planned to be deprecated in >=2.18, use the `.bash` extension for compatibility with future versions. documentaion quote: > The completion filename for command foo in this directory should be foo.bash. > Unsuffixed foo also works, but it is deprecated in >= 2.18. Passing the `bashcomplete` argument to proxmox-datacenter-api and proxmox-datacenter-privileged-api results in an error instead of generating completions. Since these binaries are systemd-managed service executables rather than user facing CLI tools, providing bash completion helpers might not be useful. Since i was not sure why we had completions for the same i added it as another patch. Please correct me if i have missed anything. [1]- https://github.com/scop/bash-completion/blob/06547b33f6de3b6f8ba730f00e7f585297a31b4f/README.md?plain=1#L184 [2]- https://packages.debian.org/en/trixie/bash-completion Testing ======= bash-completion: v2.16 I have tested by installing the completion files with .bash extension and without any extension. In both cases, the completion worked correctly. Shan Shaji (2): fix: cli: replace completion file suffix from `.bc` to `.bash` fix: cli: remove completion files for service bins Makefile | 4 ++-- cli/completions/Makefile | 2 +- debian/proxmox-datacenter-manager-client.install | 2 +- debian/proxmox-datacenter-manager.install | 8 ++------ 4 files changed, 6 insertions(+), 10 deletions(-) -- 2.47.3