From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D63A41FF13E for ; Fri, 06 Feb 2026 14:44:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A1DA33C79; Fri, 6 Feb 2026 14:45:14 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v4 3/6] api: add /remotes/tasks/refresh Date: Fri, 6 Feb 2026 14:44:30 +0100 Message-ID: <20260206134433.311230-6-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260206134433.311230-1-l.wagner@proxmox.com> References: <20260206134433.311230-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770385398206 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RVNBKPQUDDXPEM3IGKQB6MDUIFE5HDG6 X-Message-ID-Hash: RVNBKPQUDDXPEM3IGKQB6MDUIFE5HDG6 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This one allows us to trigger task fetching for a single or all remotes. Signed-off-by: Lukas Wagner Reviewed-by: Shannon Sterz --- Notes: Changes since v2: - Support to refresh multiple remotes at once - Rename paramter from 'remote' to 'remotes', since it's now an optional list of remotes - Improved documentation for the API handler server/src/api/remote_tasks.rs | 100 ++++++++++++++++++++++++++++++++- 1 file changed, 97 insertions(+), 3 deletions(-) diff --git a/server/src/api/remote_tasks.rs b/server/src/api/remote_tasks.rs index c7359166..eb1448dd 100644 --- a/server/src/api/remote_tasks.rs +++ b/server/src/api/remote_tasks.rs @@ -3,11 +3,14 @@ use std::collections::HashMap; use anyhow::Error; use pdm_api_types::{ - remotes::REMOTE_ID_SCHEMA, RemoteUpid, TaskCount, TaskFilters, TaskListItem, TaskStateType, - TaskStatistics, PRIV_RESOURCE_AUDIT, VIEW_ID_SCHEMA, + remotes::REMOTE_ID_SCHEMA, Authid, RemoteUpid, TaskCount, TaskFilters, TaskListItem, + TaskStateType, TaskStatistics, PRIV_RESOURCE_AUDIT, PRIV_RESOURCE_MODIFY, UPID, VIEW_ID_SCHEMA, }; use proxmox_access_control::CachedUserInfo; -use proxmox_router::{list_subdirs_api_method, Permission, Router, RpcEnvironment, SubdirMap}; +use proxmox_rest_server::WorkerTask; +use proxmox_router::{ + http_bail, http_err, list_subdirs_api_method, Permission, Router, RpcEnvironment, SubdirMap, +}; use proxmox_schema::api; use proxmox_sortable_macro::sortable; @@ -24,6 +27,10 @@ const SUBDIRS: SubdirMap = &sorted!([ "statistics", &Router::new().get(&API_METHOD_TASK_STATISTICS) ), + ( + "refresh", + &Router::new().post(&API_METHOD_REFRESH_REMOTE_TASKS) + ) ]); #[api( @@ -168,3 +175,90 @@ async fn task_statistics( Ok(TaskStatistics { by_type, by_remote }) } + +#[api( + input: { + properties: { + remotes: { + description: "Optional list of tasks to fetch tasks from.", + optional: true, + type: Array, + items: { + schema: REMOTE_ID_SCHEMA, + }, + }, + }, + }, + access: { + permission: &Permission::Anybody, + description: "Resource.Modify privileges are needed on /resource/{remote}", + }, + returns: { type: UPID } +)] +/// Refresh remote tasks cache. +/// +/// If `remotes` is provided, tasks will only be fetched from the provided remotes. +/// `Resource.Modify` permissions on `/resource/{remote}` are needed for every remote provided this way. +/// +/// If `remotes` is not provided, then all remotes for which the user has appropriate permissions are considered. +pub fn refresh_remote_tasks( + remotes: Option>, + rpcenv: &mut dyn RpcEnvironment, +) -> Result { + let (config, _digest) = pdm_config::remotes::config()?; + + let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; + let user_info = CachedUserInfo::new()?; + + let remotes = if let Some(remotes) = remotes { + let mut configs = Vec::new(); + + for remote in &remotes { + if user_info + .check_privs(&auth_id, &["resource", remote], PRIV_RESOURCE_MODIFY, false) + .is_err() + { + http_bail!(FORBIDDEN, "user has no access to this remote"); + } + let remote = config + .get(remote) + .ok_or_else(|| http_err!(NOT_FOUND, "remote does not exist"))?; + + configs.push(remote.clone()); + } + + configs + } else { + if !user_info.any_privs_below(&auth_id, &["resource"], PRIV_RESOURCE_MODIFY)? { + http_bail!(FORBIDDEN, "user has no access to resources"); + } + + config + .into_iter() + .filter_map(|(remote_name, remote)| { + user_info + .check_privs( + &auth_id, + &["resource", &remote_name], + PRIV_RESOURCE_MODIFY, + false, + ) + .is_ok() + .then_some(remote) + }) + .collect() + }; + + let upid_str = WorkerTask::spawn( + "refresh-remote-tasks", + None, + auth_id.to_string(), + true, + |_worker| async { + remote_tasks::refresh_task::refresh_taskcache(remotes).await?; + Ok(()) + }, + )?; + + upid_str.parse() +} -- 2.47.3