From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E56B61FF13E for ; Fri, 06 Feb 2026 11:18:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B741223BD4; Fri, 6 Feb 2026 11:19:21 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v2] fix #7120: remote updates: drop vanished nodes/remotes from cache file Date: Fri, 6 Feb 2026 11:19:14 +0100 Message-ID: <20260206101914.152925-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770373078281 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TXBS5UR2R4UYS3LF6OQGYG46FRR2LE6B X-Message-ID-Hash: TXBS5UR2R4UYS3LF6OQGYG46FRR2LE6B X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This commits makes sure that vanished remotes and remote cluster nodes are dropped from the remote updates cache file. This happens whenever the cache file is fully refreshed, either by the periodic update task, or by pressing "Refresh All" in the UI. Signed-off-by: Lukas Wagner --- Notes: Changes since v1: - rebased on top of the parallel fetcher changes [0] - these need to be applied first! [0]: https://lore.proxmox.com/all/20260206094304.117465-1-l.wagner@proxmox.com/T/#u server/src/remote_updates.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/server/src/remote_updates.rs b/server/src/remote_updates.rs index 2762001e..7aaacc46 100644 --- a/server/src/remote_updates.rs +++ b/server/src/remote_updates.rs @@ -214,6 +214,11 @@ pub async fn refresh_update_summary_cache(remotes: Vec) -> Result<(), Er let mut content = get_cached_summary_or_default()?; + // Clean out any remotes that might have been removed from the remote config in the meanwhile. + content + .remotes + .retain(|remote, _| fetch_response.iter().any(|r| r.remote() == remote)); + for remote_response in fetch_response { let remote_name = remote_response.remote().to_string(); @@ -228,6 +233,11 @@ pub async fn refresh_update_summary_cache(remotes: Vec) -> Result<(), Er match remote_response.nodes() { Ok(node_responses) => { + // Clean out any nodes that might have been removed from the cluster in the meanwhile. + entry + .nodes + .retain(|name, _| node_responses.iter().any(|n| n.node_name() == name)); + entry.status = RemoteUpdateStatus::Success; for node_response in node_responses { -- 2.47.3