From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 280E61FF13D for ; Thu, 08 Jan 2026 14:06:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6D3522DC2; Thu, 8 Jan 2026 14:06:55 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Date: Thu, 8 Jan 2026 14:06:49 +0100 Message-ID: <20260108130649.210778-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767877574197 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager] fix #7120: remote updates: drop vanished nodes/remotes from cache file X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" This commits makes sure that vanished remotes and remote cluster nodes are dropped from the remote updates cache file. This happens whenever the cache file is fully refreshed, either by the periodic update task, or by pressing "Refresh All" in the UI. Signed-off-by: Lukas Wagner --- server/src/remote_updates.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/server/src/remote_updates.rs b/server/src/remote_updates.rs index e772eef5..0490d28e 100644 --- a/server/src/remote_updates.rs +++ b/server/src/remote_updates.rs @@ -214,6 +214,11 @@ pub async fn refresh_update_summary_cache(remotes: Vec) -> Result<(), Er let mut content = get_cached_summary_or_default()?; + // Clean out any remotes that might have been removed from the remote config in the meanwhile. + content + .remotes + .retain(|remote, _| fetch_results.remote_results.contains_key(remote)); + for (remote_name, result) in fetch_results.remote_results { let entry = content .remotes @@ -234,6 +239,11 @@ pub async fn refresh_update_summary_cache(remotes: Vec) -> Result<(), Er Ok(remote_result) => { entry.status = RemoteUpdateStatus::Success; + // Clean out any nodes that might have been removed from the cluster in the meanwhile. + entry + .nodes + .retain(|name, _| remote_result.node_results.contains_key(name)); + for (node_name, node_result) in remote_result.node_results { match node_result { Ok(NodeResults { data, .. }) => { -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel