From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8A3201FF178 for ; Mon, 29 Dec 2025 17:17:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 39C3D1E93C; Mon, 29 Dec 2025 17:18:48 +0100 (CET) From: Maximiliano Sandoval To: pdm-devel@lists.proxmox.com Date: Mon, 29 Dec 2025 17:18:36 +0100 Message-ID: <20251229161844.49433-2-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251229161844.49433-1-m.sandoval@proxmox.com> References: <20251229161844.49433-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767025098077 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 1/7] remove needless borrows X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Detected by clippy. Signed-off-by: Maximiliano Sandoval --- cli/client/src/subscriptions.rs | 2 +- server/src/api/nodes/sdn.rs | 2 +- server/src/api/remote_shell.rs | 4 ++-- server/src/api/resources.rs | 2 +- server/src/auth/mod.rs | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cli/client/src/subscriptions.rs b/cli/client/src/subscriptions.rs index bf450a5f..d8bf1e09 100644 --- a/cli/client/src/subscriptions.rs +++ b/cli/client/src/subscriptions.rs @@ -87,7 +87,7 @@ async fn get_subscription_status( let mut node_status = node_status.iter().collect::>(); - node_status.sort_by(|a, b| a.0.cmp(&b.0)); + node_status.sort_by(|a, b| a.0.cmp(b.0)); for (node, info) in node_status { let Some(info) = info else { println!(" {node}"); diff --git a/server/src/api/nodes/sdn.rs b/server/src/api/nodes/sdn.rs index 065ebe07..af5b7536 100644 --- a/server/src/api/nodes/sdn.rs +++ b/server/src/api/nodes/sdn.rs @@ -80,7 +80,7 @@ mod vnets { ) -> Result, Error> { let (remote_config, _) = pdm_config::remotes::config()?; let remote = get_remote(&remote_config, &remote)?; - let client = connect(&remote)?; + let client = connect(remote)?; client .get_vnet_mac_vrf(&node, &vnet) diff --git a/server/src/api/remote_shell.rs b/server/src/api/remote_shell.rs index c617b4dc..9a1dc183 100644 --- a/server/src/api/remote_shell.rs +++ b/server/src/api/remote_shell.rs @@ -171,7 +171,7 @@ fn upgrade_to_websocket( let remote = get_remote(&remotes, &remote)?; let (ticket, port) = match remote.ty { RemoteType::Pve => { - let pve = crate::connection::make_pve_client(&remote)?; + let pve = crate::connection::make_pve_client(remote)?; let pve_term_ticket = pve .node_shell_termproxy( &node, @@ -184,7 +184,7 @@ fn upgrade_to_websocket( (pve_term_ticket.ticket, pve_term_ticket.port) } RemoteType::Pbs => { - let pbs = crate::connection::make_pbs_client(&remote)?; + let pbs = crate::connection::make_pbs_client(remote)?; let pbs_term_ticket = pbs.node_shell_termproxy().await?; (pbs_term_ticket.ticket, pbs_term_ticket.port as i64) } diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs index c97644ad..ecccb94a 100644 --- a/server/src/api/resources.rs +++ b/server/src/api/resources.rs @@ -139,7 +139,7 @@ fn resource_matches_search_term( MatchCategory::RemoteType => return None, MatchCategory::NetworkType => match resource { Resource::PveNetwork(network_resource) => { - category.matches(&network_resource.network_type().as_str(), &term.value) + category.matches(network_resource.network_type().as_str(), &term.value) } _ => false, }, diff --git a/server/src/auth/mod.rs b/server/src/auth/mod.rs index 0d6bcddc..82425e8c 100644 --- a/server/src/auth/mod.rs +++ b/server/src/auth/mod.rs @@ -167,7 +167,7 @@ impl proxmox_auth_api::api::AuthContext for PdmAuthContext { path_vec.push(part); } } - user_info.check_privs(&auth_id, &path_vec, *privilege, false)?; + user_info.check_privs(auth_id, &path_vec, *privilege, false)?; return Ok(Some(true)); } } -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel