From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C9FF71FF178 for ; Mon, 29 Dec 2025 17:18:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EAFBA1EA49; Mon, 29 Dec 2025 17:19:18 +0100 (CET) From: Maximiliano Sandoval To: pdm-devel@lists.proxmox.com Date: Mon, 29 Dec 2025 17:18:35 +0100 Message-ID: <20251229161844.49433-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767025098019 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 0/7] clippy fixes for 1.90 X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" This was spotted with clippy 0.1.90 and rustc 1.90. After this, there is only one renaming clippy lint after running Clippy, namely: ``` $ cargo clippy --all-targets --workspace --all-features warning: this function has too many arguments (8/7) --> lib/pdm-client/src/lib.rs:1093:5 | 1093 | / pub async fn pve_list_storages( 1094 | | &self, 1095 | | remote: &str, 1096 | | node: &str, ... | 1101 | | target: Option, 1102 | | ) -> Result, Error> { | |________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default warning: `pdm-client` (lib) generated 1 warning warning: `pdm-client` (lib test) generated 1 warning (1 duplicate) Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s ``` Maximiliano Sandoval (7): remove needless borrows simplify if-else block remote tasks: remove unneeded enclosing Ok() and ? firewall: prefer is_some_and over map_or false subscription: remove unneeded return statement api: resources: collapse identical if blocks api: resources: rewrite let-else block with ? cli/admin/src/remotes.rs | 2 +- cli/client/src/subscriptions.rs | 2 +- server/src/api/nodes/sdn.rs | 2 +- server/src/api/nodes/subscription.rs | 2 +- server/src/api/pve/firewall.rs | 2 +- server/src/api/remote_shell.rs | 4 +-- server/src/api/resources.rs | 29 +++++++++---------- server/src/auth/mod.rs | 2 +- .../tasks/remote_tasks.rs | 4 +-- 9 files changed, 23 insertions(+), 26 deletions(-) -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel