From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4289A1FF17C for ; Tue, 16 Dec 2025 15:38:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E587126F8; Tue, 16 Dec 2025 15:39:01 +0100 (CET) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Date: Tue, 16 Dec 2025 15:38:55 +0100 Message-ID: <20251216143856.302676-2-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251216143856.302676-1-s.sterz@proxmox.com> References: <20251216143856.302676-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765895929525 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH yew-widget-toolkit v2 1/1] tab bar: make `TabBarItem::tip` work as intended X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" previously setting a tooltip via the `tip()` function of an `TabBarItem` had no effect. so actually render a tooltip with the provided `VNode` as content if a tooltip is set on a `TabBarItem` Signed-off-by: Shannon Sterz --- src/widget/tab/tab_bar.rs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/widget/tab/tab_bar.rs b/src/widget/tab/tab_bar.rs index d3de24f5..44fb9f39 100644 --- a/src/widget/tab/tab_bar.rs +++ b/src/widget/tab/tab_bar.rs @@ -8,7 +8,7 @@ use crate::dom::{element_direction_rtl, DomSizeObserver, IntoHtmlElement}; use crate::props::{IntoStorageLocation, StorageLocation}; use crate::state::{NavigationContext, NavigationContextExt, PersistentState, Selection}; use crate::web_sys_ext::{ResizeObserverBoxOptions, ResizeObserverOptions}; -use crate::widget::Container; +use crate::widget::{Container, Tooltip}; use crate::{impl_class_prop_builder, impl_yew_std_props_builder, prelude::*}; use super::TabBarItem; @@ -464,7 +464,7 @@ impl Component for PwtTabBar { let aria_disabled = if disabled { "true" } else { "false" }; let style = format!("grid-column: {};", i + 1); - html! { + let content = html! { if let Some(class) = &panel.icon_class { @@ -473,6 +473,12 @@ impl Component for PwtTabBar { {panel.label.as_deref().unwrap_or("")} + }; + + if let Some(tip) = panel.tip.clone() { + Tooltip::new(content).rich_tip(tip).into() + } else { + content } }) .collect::(); -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel