From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C94F31FF179 for ; Wed, 10 Dec 2025 17:38:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8A6DF17A1; Wed, 10 Dec 2025 17:38:58 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Date: Wed, 10 Dec 2025 17:37:29 +0100 Message-ID: <20251210163736.384795-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765384695846 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs, remotes.rs, mod.rs, config.rs, code.rs, generate.pl, proxmox.com] URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [188.114.96.3] Subject: [pdm-devel] [PATCH datacenter-manager/proxmox v2 0/7] fix #6914: add option to remove already existing token X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" If a user removed a remote without deleting its associated token, PDM would not allow re-adding the same remote unless the token was changed. To fix this, support for optionally deleting the token from the remote has been added. This patch series adds support to delete the token using an optional boolean flag in CLIs ie. on both admin and client. Additionaly, also added a check box inside the UI that allow users to choose whether to delete the token while removing the remote. History ======= patch: https://lore.proxmox.com/pdm-devel/DETUIY1JX929.1PHFNA7IHWJZ5@proxmox.com/T/#t changes since v1: - Locked the remote config inorder to avoid race condition. Thanks @Michael - Included missing admin cli implementation. Thanks @Michael - Addressed nit comments. Thanks @Shannon proxmox-datacenter-manager: Shan Shaji (6): server: pbs-client: add delete admin token method server: api: add support to optionally delete token from remote pdm-client: accept `delete-token` argument for deleting api token cli: client: add `delete-token` option to delete token from remote fix: ui: add remove confirmation dialog with optional token deletion cli: admin: add `delete-token` option to delete token from remote cli/admin/src/remotes.rs | 20 ++++-- cli/client/src/remotes.rs | 11 ++- lib/pdm-client/src/lib.rs | 11 ++- server/src/api/remotes.rs | 46 ++++++++++++- server/src/pbs_client.rs | 7 ++ ui/src/remotes/config.rs | 38 ++++++++--- ui/src/remotes/mod.rs | 2 + ui/src/remotes/remove_remote.rs | 117 ++++++++++++++++++++++++++++++++ 8 files changed, 231 insertions(+), 21 deletions(-) create mode 100644 ui/src/remotes/remove_remote.rs proxmox: Shan Shaji (1): pve-api-types: generate missing `delete_token` method pve-api-types/generate.pl | 1 + pve-api-types/src/generated/code.rs | 11 +++++++++++ 2 files changed, 12 insertions(+) Summary over all repositories: 10 files changed, 243 insertions(+), 21 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel