From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0F8C91FF1A6 for ; Fri, 5 Dec 2025 12:05:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 313FC14B2A; Fri, 5 Dec 2025 12:05:34 +0100 (CET) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Fri, 5 Dec 2025 12:04:54 +0100 Message-ID: <20251205110500.1521091-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251205110500.1521091-1-d.csapak@proxmox.com> References: <20251205110500.1521091-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager 2/2] server: api: pbs: improve error message for datastore content X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" the code here looks for the response code to determine what to do, but since the 'extjs' formatter is used, that's always 200, so it's always attempted to parse the body like a successful api call. Change the api call to use the 'json' formatter, which correctly sets the response code directly and not in the body. This fixes an issue with a very non-informative error message when a pbs datastore has an error (e.g. no '.chunks' folder) like missing field `data` at line 1 column xy instead of the actual error message from the api call. Signed-off-by: Dominik Csapak --- server/src/pbs_client.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/server/src/pbs_client.rs b/server/src/pbs_client.rs index f4f1f820..3f3d2b5f 100644 --- a/server/src/pbs_client.rs +++ b/server/src/pbs_client.rs @@ -185,10 +185,9 @@ impl PbsClient { datastore: &str, namespace: Option<&str>, ) -> Result, anyhow::Error> { - let path = - ApiPathBuilder::new(format!("/api2/extjs/admin/datastore/{datastore}/snapshots")) - .maybe_arg("ns", &namespace) - .build(); + let path = ApiPathBuilder::new(format!("/api2/json/admin/datastore/{datastore}/snapshots")) + .maybe_arg("ns", &namespace) + .build(); let response = self .0 .streaming_request(http::Method::GET, &path, None::<()>) -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel