From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 399F41FF184 for ; Thu, 4 Dec 2025 15:24:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA35A1905; Thu, 4 Dec 2025 15:25:25 +0100 (CET) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Thu, 4 Dec 2025 15:20:29 +0100 Message-ID: <20251204142451.2992215-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251204142451.2992215-1-d.csapak@proxmox.com> References: <20251204142451.2992215-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" In most of the UI, we use 'server' for remotes, 'building' for PVE nodes and 'building-o' for PBS nodes. In the main menu we don't have the information if a remote is a single node or not for PVE, but we know if it's PBS. So show the 'building-o' for PBS remotes. This makes it possible to see which kind of remote it is before clicking, and wihtout inventing a custom naming scheme. Signed-off-by: Dominik Csapak --- We can of course choose different icons here if wanted, e.g. 'floppy-o' for pbs remotes? Maybe the best option would be to create some custom product icons that we could use here and maybe for the favicon, etc. ? ui/src/main_menu.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/src/main_menu.rs b/ui/src/main_menu.rs index 18988eaf..8d44d8f1 100644 --- a/ui/src/main_menu.rs +++ b/ui/src/main_menu.rs @@ -347,7 +347,10 @@ impl Component for PdmMainMenu { &mut content, &remote.id, &format!("remote-{}", remote.id), - Some("fa fa-server"), + match remote.ty { + RemoteType::Pve => Some("fa fa-fw fa-server"), + RemoteType::Pbs => Some("fa fa-fw fa-building-o"), + }, { let remote = remote.clone(); move |_| match remote.ty { -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel