From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2507C1FF178 for ; Mon, 1 Dec 2025 17:45:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A5695225DD; Mon, 1 Dec 2025 17:46:07 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Date: Mon, 1 Dec 2025 17:46:00 +0100 Message-ID: <20251201164600.413879-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764607522469 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager v2] ui: use explicit parameter indices in tr macros X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" The order of parameters can change in translations, so it is important to use explicit indexing when there are *multiple* parameters. The gettext runtime shows warnings in the browser console for these: "... multiple non-indexed, non-named arguments - order is implicit" Signed-off-by: Lukas Wagner --- Changes since v1: - Actually only add indices if there are *multiple* parameters. ui/src/remotes/firewall/ui_helpers.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/src/remotes/firewall/ui_helpers.rs b/ui/src/remotes/firewall/ui_helpers.rs index 741064d8..7aa2e05e 100644 --- a/ui/src/remotes/firewall/ui_helpers.rs +++ b/ui/src/remotes/firewall/ui_helpers.rs @@ -89,7 +89,7 @@ impl PanelConfig { let mut rules = proxmox_yew_comp::FirewallRules::node(remote.to_string(), node.to_string()); rules.reload_token = reload_token; Self { - title: create_panel_title("list", tr!("Node Firewall Rules - {}/{}", remote, node)), + title: create_panel_title("list", tr!("Node Firewall Rules - {0}/{1}", remote, node)), key: format!("node-{}-{}", remote, node), content: rules.into(), title_prefix: None, @@ -115,7 +115,7 @@ impl PanelConfig { title: create_panel_title( "list", tr!( - "Guest Firewall Rules - {}/{}/{} {}", + "Guest Firewall Rules - {0}/{1}/{2} {3}", remote, node, vmtype.to_uppercase(), -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel