From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8DB6E1FF15C for ; Fri, 28 Nov 2025 13:33:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B28F51A015; Fri, 28 Nov 2025 13:33:33 +0100 (CET) From: Dietmar Maurer To: pdm-devel@lists.proxmox.com Date: Fri, 28 Nov 2025 13:33:28 +0100 Message-ID: <20251128123328.1652152-1-dietmar@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.579 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pdm-devel] [PATCH datacenter-manager] pdm: api: get_network: rename parameter interface-type to type X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Use the same parameter name as in the pve api. Else we need to translate parameter names for GUI components that works on both pve and pdm api. Signed-off-by: Dietmar Maurer --- lib/pdm-client/src/lib.rs | 2 +- server/src/api/pve/node.rs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs index 29e9e7a..3d2135d 100644 --- a/lib/pdm-client/src/lib.rs +++ b/lib/pdm-client/src/lib.rs @@ -1090,7 +1090,7 @@ impl PdmClient { let path = ApiPathBuilder::new(format!( "/api2/extjs/pve/remotes/{remote}/nodes/{node}/network" )) - .maybe_arg("interface-type", &interface_type) + .maybe_arg("type", &interface_type) .build(); Ok(self.0.get(&path).await?.expect_json()?.data) } diff --git a/server/src/api/pve/node.rs b/server/src/api/pve/node.rs index 9249711..708aabf 100644 --- a/server/src/api/pve/node.rs +++ b/server/src/api/pve/node.rs @@ -58,7 +58,7 @@ const STORAGE_ROUTER: Router = Router::new() properties: { remote: { schema: REMOTE_ID_SCHEMA }, node: { schema: NODE_SCHEMA }, - "interface-type": { + type: { type: pve_api_types::ListNetworksType, optional: true, }, @@ -72,11 +72,11 @@ const STORAGE_ROUTER: Router = Router::new() async fn get_network( remote: String, node: String, - interface_type: Option, + r#type: Option, ) -> Result, Error> { let (remotes, _) = pdm_config::remotes::config()?; let client = super::connect_to_remote(&remotes, &remote)?; - let networks = client.list_networks(&node, interface_type).await?; + let networks = client.list_networks(&node, r#type).await?; Ok(networks) } -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel