From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3D8591FF179 for ; Wed, 12 Nov 2025 14:20:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D09F833E8; Wed, 12 Nov 2025 14:20:54 +0100 (CET) From: Gabriel Goller To: pdm-devel@lists.proxmox.com Date: Wed, 12 Nov 2025 14:20:23 +0100 Message-ID: <20251112132045.165444-7-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251112132045.165444-1-g.goller@proxmox.com> References: <20251112132045.165444-1-g.goller@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762953625124 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 6/9] api: sdn: add granular permissions for vnets X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Add granular permission for sdn vnets. So you can specify `/resource/{remote}/sdn/vnet/{vnet-name}`. Signed-off-by: Gabriel Goller --- server/src/api/sdn/vnets.rs | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/server/src/api/sdn/vnets.rs b/server/src/api/sdn/vnets.rs index ebd28742aa25..3c4397072f92 100644 --- a/server/src/api/sdn/vnets.rs +++ b/server/src/api/sdn/vnets.rs @@ -57,7 +57,7 @@ pub const ROUTER: Router = Router::new() permission: &Permission::Anybody, description: "The user needs to have at least the `Resource.Audit` privilege under `/resource`. Only vnets from remotes for which the user has `Resource.Audit` on `/resource/{remote_name}` - will be included in the returned list." + and `/resource/{remote_name}/sdn/vnet/{vnet}` will be included in the returned list." } )] /// Query VNets of PVE remotes with optional filtering options @@ -110,12 +110,20 @@ async fn list_vnets( Ok(remote_result) => { for (node, node_result) in remote_result.node_results.into_iter() { match node_result { - Ok(NodeResults { data, .. }) => { - vnets.extend(data.into_iter().map(|vnet| ListVnet { - remote: remote.clone(), - vnet, - })) - } + Ok(NodeResults { data, .. }) => vnets.extend( + data.into_iter() + .filter(|vnet| { + user_info.lookup_privs( + &auth_id, + &["resource", &remote, "sdn", "vnet", &vnet.vnet], + ) & PRIV_RESOURCE_AUDIT + != 0 + }) + .map(|vnet| ListVnet { + remote: remote.clone(), + vnet, + }), + ), Err(error) => { log::error!( "could not fetch vnets from remote {} node {}: {error:#}", -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel