public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH access-control/manager/proxmox{, -backup, -yew-comp, -datacenter-manager}/xtermjs 00/25] add remote node shell
Date: Tue, 11 Nov 2025 09:29:07 +0100	[thread overview]
Message-ID: <20251111082938.221008-1-f.gruenbichler@proxmox.com> (raw)

there's a lot of inter-dependencies here, unfortunately.

proxmox-auth-api breaks (building) PBS and PDM, and PBS requires bumped
proxmox-auth-api for this series to work.
PBS and PVE require new termproxy
pve-manager requires new pve-access-control (via termproxy)
PBS requires new pbs-api-types
PDM requires new pbs-api-types, pve-api-types, proxmox-yew-comp and pve-xtermjs

suggested build-order:
- pve-xtermjs / proxmox-termproxy
- pve-access-control
- pve-manager
- pve-api-types
- pbs-api-types
- proxmox-auth-api
- PBS
- proxmox-yew-comp
- PDM

the remote shell only works if remotes have new enough PVE/PBS packages.

pve-xtermjs:

Fabian Grünbichler (2):
  xtermjs: add support for remote node shells via PDM
  termproxy: allow using new vncticket endpoint

 termproxy/src/cli.rs  |  5 +++++
 termproxy/src/main.rs | 31 ++++++++++++++++++++++---------
 xterm.js/src/main.js  | 13 +++++++++++--
 3 files changed, 38 insertions(+), 11 deletions(-)


pve-access-control:

Fabian Grünbichler (1):
  api: ticket: allow token-owned VNC ticket verification

 src/PVE/API2/AccessControl.pm | 60 +++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)


pve-manager:

Fabian Grünbichler (3):
  api: termproxy/vncwebsocket: allow tokens
  api: termproxy: add description to return schema
  http server: allow unauthenticated access to /access/vncticket

 PVE/API2/Nodes.pm | 17 ++++++++++-------
 PVE/HTTPServer.pm |  1 +
 2 files changed, 11 insertions(+), 7 deletions(-)


proxmox:

Fabian Grünbichler (3):
  pbs-api-types: add NodeShellTicket
  auth-api: use Authid for path ticket validation
  auth-api: add vncticket verification endpoint and type

 pbs-api-types/src/node.rs          | 36 +++++++++++++++++++++++++++++-
 proxmox-auth-api/src/api/access.rs | 34 ++++++++++++++++++++++++++--
 proxmox-auth-api/src/api/mod.rs    |  8 +++----
 proxmox-auth-api/src/types.rs      | 22 ++++++++++++++++++
 4 files changed, 93 insertions(+), 7 deletions(-)


proxmox-backup:

Fabian Grünbichler (4):
  tree-wide: user Userid::root_user() instead of hard-coded root@pam
  api: access: add vncticket verification endpoint
  api: node shell: allow access for tokens
  api: termproxy: use NodeShellTicket type from pbs-api-types

 pbs-config/src/acl.rs              |  2 +-
 pbs-config/src/cached_user_info.rs |  4 +-
 pbs-config/src/user.rs             |  5 ++-
 src/api2/access/mod.rs             |  6 ++-
 src/api2/node/mod.rs               | 66 +++++++++---------------------
 src/auth.rs                        |  5 +--
 src/tools/ticket.rs                |  6 +--
 7 files changed, 36 insertions(+), 58 deletions(-)


proxmox-yew-comp:

Fabian Grünbichler (3):
  xtermjs: add remote PVE support
  xtermjs: merge ConsoleType to parameters conversion
  xtermjs: add remote PBS console type

 src/xtermjs.rs | 41 ++++++++++++++++++++++++++---------------
 1 file changed, 26 insertions(+), 15 deletions(-)


proxmox-datacenter-manager:

Fabian Grünbichler (9):
  auth: allow tokens in term tickets
  connection: add access to "raw" client
  pbs client: add termproxy wrapper
  api: add remote_shell module with termproxy endpoint
  api: remote shell: add websocket endpoint
  api: pve: wire up remote shell support
  ui: pve: node: add shell tab
  api: pbs: wire up node shell endpoints
  ui: add PBS remote shell button

 Cargo.toml                                    |   2 +-
 debian/control                                |  12 +-
 server/src/api/mod.rs                         |   1 +
 server/src/api/pbs/node.rs                    |  12 +-
 server/src/api/pve/node.rs                    |   8 +
 server/src/api/remote_shell.rs                | 261 ++++++++++++++++++
 server/src/auth/mod.rs                        |   5 +-
 server/src/connection.rs                      |  11 +
 .../src/metric_collection/collection_task.rs  |   5 +
 server/src/pbs_client.rs                      |   6 +
 server/src/test_support/fake_remote.rs        |   5 +
 ui/src/pbs/mod.rs                             |  18 +-
 ui/src/pve/node/mod.rs                        |  18 +-
 13 files changed, 351 insertions(+), 13 deletions(-)
 create mode 100644 server/src/api/remote_shell.rs


Summary over all repositories:
  31 files changed, 615 insertions(+), 111 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

             reply	other threads:[~2025-11-11  8:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-11  8:29 Fabian Grünbichler [this message]
2025-11-11  8:29 ` [pdm-devel] [PATCH pve-xtermjs 1/2] xtermjs: add support for remote node shells via PDM Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH pve-xtermjs 2/2] termproxy: allow using new vncticket endpoint Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH access-control 1/1] api: ticket: allow token-owned VNC ticket verification Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH manager 1/3] api: termproxy/vncwebsocket: allow tokens Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH manager 2/3] api: termproxy: add description to return schema Fabian Grünbichler
2025-11-13 10:38   ` Stefan Hanreich
2025-11-11  8:29 ` [pdm-devel] [PATCH manager 3/3] http server: allow unauthenticated access to /access/vncticket Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox 1/3] pbs-api-types: add NodeShellTicket Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox 2/3] auth-api: use Authid for path ticket validation Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox 3/3] auth-api: add vncticket verification endpoint and type Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-backup 1/4] tree-wide: user Userid::root_user() instead of hard-coded root@pam Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-backup 2/4] api: access: add vncticket verification endpoint Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-backup 3/4] api: node shell: allow access for tokens Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-backup 4/4] api: termproxy: use NodeShellTicket type from pbs-api-types Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-yew-comp 1/3] xtermjs: add remote PVE support Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-yew-comp 2/3] xtermjs: merge ConsoleType to parameters conversion Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-yew-comp 3/3] xtermjs: add remote PBS console type Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/9] auth: allow tokens in term tickets Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/9] connection: add access to "raw" client Fabian Grünbichler
2025-11-13 10:39   ` Stefan Hanreich
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 3/9] pbs client: add termproxy wrapper Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 4/9] api: add remote_shell module with termproxy endpoint Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 5/9] api: remote shell: add websocket endpoint Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 6/9] api: pve: wire up remote shell support Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 7/9] ui: pve: node: add shell tab Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 8/9] api: pbs: wire up node shell endpoints Fabian Grünbichler
2025-11-11  8:29 ` [pdm-devel] [PATCH proxmox-datacenter-manager 9/9] ui: add PBS remote shell button Fabian Grünbichler
2025-11-13 10:40 ` [pdm-devel] [PATCH access-control/manager/proxmox{, -backup, -yew-comp, -datacenter-manager}/xtermjs 00/25] add remote node shell Stefan Hanreich
2025-11-14 11:04 ` [pdm-devel] partially-applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251111082938.221008-1-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal