From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3AACB1FF15E for ; Mon, 10 Nov 2025 09:57:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5EF2F101DF; Mon, 10 Nov 2025 09:58:35 +0100 (CET) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Date: Mon, 10 Nov 2025 09:58:29 +0100 Message-ID: <20251110085830.21887-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251110085830.21887-1-s.sterz@proxmox.com> References: <20251110085830.21887-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762765089777 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH yew-comp v3 2/2] node status panel: remove power management and make fingerprint opt-in X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" the panel appeared to dense with all these tools being present. so remove the reboot and power off button and make the fingerprint button opt-in. Signed-off-by: Shannon Sterz --- src/node_status_panel.rs | 70 ++++++++++------------------------------ 1 file changed, 17 insertions(+), 53 deletions(-) diff --git a/src/node_status_panel.rs b/src/node_status_panel.rs index 3d37d80..c73594b 100644 --- a/src/node_status_panel.rs +++ b/src/node_status_panel.rs @@ -12,12 +12,11 @@ use pwt::widget::{error_message, Fa, Panel, Row, Tooltip}; use pwt::widget::{Button, Dialog}; use pwt_macros::builder; -use proxmox_node_status::{NodePowerCommand, NodeStatus}; +use proxmox_node_status::NodeStatus; use crate::utils::copy_text_to_clipboard; use crate::{ - http_get, http_post, node_info, ConfirmButton, LoadableComponent, LoadableComponentContext, - LoadableComponentMaster, + http_get, node_info, LoadableComponent, LoadableComponentContext, LoadableComponentMaster, }; #[derive(Properties, Clone, PartialEq)] @@ -27,6 +26,10 @@ pub struct NodeStatusPanel { #[builder(IntoPropValue, into_prop_value)] #[prop_or_default] status_base_url: Option, + + #[builder(IntoPropValue, into_prop_value)] + #[prop_or_default] + fingerprint_button: bool, } impl NodeStatusPanel { @@ -44,8 +47,6 @@ impl Default for NodeStatusPanel { enum Msg { Error(Error), Loaded(Rc), - RebootOrShutdown(NodePowerCommand), - Reload, } #[derive(PartialEq)] @@ -59,24 +60,6 @@ struct ProxmoxNodeStatusPanel { } impl ProxmoxNodeStatusPanel { - fn change_power_state(&self, ctx: &LoadableComponentContext, command: NodePowerCommand) { - let Some(url) = ctx.props().status_base_url.clone() else { - return; - }; - let link = ctx.link().clone(); - - ctx.link().spawn(async move { - let data = Some(serde_json::json!({ - "command": command, - })); - - match http_post(url.as_str(), data).await { - Ok(()) => link.send_message(Msg::Reload), - Err(err) => link.send_message(Msg::Error(err)), - } - }); - } - fn fingerprint_dialog( &self, ctx: &LoadableComponentContext, @@ -154,7 +137,7 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { }) } - fn update(&mut self, ctx: &crate::LoadableComponentContext, msg: Self::Message) -> bool { + fn update(&mut self, _ctx: &crate::LoadableComponentContext, msg: Self::Message) -> bool { match msg { Msg::Error(err) => { self.error = Some(err); @@ -165,11 +148,6 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { self.error = None; true } - Msg::RebootOrShutdown(command) => { - self.change_power_state(ctx, command); - false - } - Msg::Reload => true, } } @@ -195,7 +173,7 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { .as_ref() .map(|r| crate::NodeStatus::Common(r)); - Panel::new() + let mut panel = Panel::new() .border(false) .class(FlexFit) .title( @@ -206,25 +184,11 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { .with_child(tr!("Node Status")) .into_html(), ) - .with_tool( - ConfirmButton::new(tr!("Reboot")) - .confirm_message(tr!("Are you sure you want to reboot the node?")) - .on_activate( - ctx.link() - .callback(|_| Msg::RebootOrShutdown(NodePowerCommand::Reboot)), - ) - .icon_class("fa fa-undo"), - ) - .with_tool( - ConfirmButton::new(tr!("Shutdown")) - .confirm_message(tr!("Are you sure you want to shut down the node?")) - .on_activate( - ctx.link() - .callback(|_| Msg::RebootOrShutdown(NodePowerCommand::Shutdown)), - ) - .icon_class("fa fa-power-off"), - ) - .with_tool( + .with_child(node_info(status)) + .with_optional_child(self.error.as_ref().map(|e| error_message(&e.to_string()))); + + if ctx.props().fingerprint_button { + panel.add_tool( Button::new(tr!("Show Fingerprint")) .icon_class("fa fa-hashtag") .class(ColorScheme::Primary) @@ -232,10 +196,10 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { ctx.link() .change_view_callback(|_| ViewState::FingerprintDialog), ), - ) - .with_child(node_info(status)) - .with_optional_child(self.error.as_ref().map(|e| error_message(&e.to_string()))) - .into() + ); + } + + panel.into() } } -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel