From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 89B5E1FF191 for ; Tue, 4 Nov 2025 15:49:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F37A10304; Tue, 4 Nov 2025 15:49:56 +0100 (CET) From: Christian Ebner To: pdm-devel@lists.proxmox.com Date: Tue, 4 Nov 2025 15:49:05 +0100 Message-ID: <20251104144905.582920-5-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251104144905.582920-1-c.ebner@proxmox.com> References: <20251104144905.582920-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762267745120 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 3/3] ui: datastore tree: indicate datastore type by different icons X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Make it already from the tree view apparent which datastores are removable and which have s3 backend. Fallback to the default if neither of these is the case or the config could not be parsed. Signed-off-by: Christian Ebner --- ui/src/pbs/tree.rs | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/ui/src/pbs/tree.rs b/ui/src/pbs/tree.rs index f804665..09d777a 100644 --- a/ui/src/pbs/tree.rs +++ b/ui/src/pbs/tree.rs @@ -14,7 +14,7 @@ use pwt::widget::data_table::{DataTable, DataTableColumn, DataTableHeader}; use pwt::widget::form::Field; use pwt::widget::{ActionIcon, Button, Column, Container, Fa, Row, Toolbar, Tooltip, Trigger}; -use pbs_api_types::DataStoreConfig; +use pbs_api_types::{DataStoreConfig, DatastoreBackendType}; use crate::get_deep_url; use crate::renderer::render_tree_column; @@ -290,10 +290,22 @@ fn columns( Container::new().with_child(Fa::new("server")), remote_name.clone(), ), - PbsTreeNode::Datastore(datastore) => ( - Container::new().with_child(Fa::new("database")), - datastore.name.clone(), - ), + PbsTreeNode::Datastore(datastore) => { + let backend_config = datastore.parse_backend_config().unwrap_or_default(); + let backend_s3 = match backend_config.ty.unwrap_or_default() { + DatastoreBackendType::Filesystem => false, + DatastoreBackendType::S3 => true, + }; + let icon = if datastore.backing_device.is_some() { + Fa::new("plug") + } else if backend_s3 { + Fa::new("cloud-upload") + } else { + Fa::new("database") + }; + + (Container::new().with_child(icon), datastore.name.clone()) + } }; render_tree_column(icon.into(), text).into() }) -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel