From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B1FFD1FF179 for ; Wed, 29 Oct 2025 15:15:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C28D9CFD6; Wed, 29 Oct 2025 15:16:07 +0100 (CET) From: Fiona Ebner To: pdm-devel@lists.proxmox.com Date: Wed, 29 Oct 2025 15:14:03 +0100 Message-ID: <20251029141559.142782-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251029141559.142782-1-f.ebner@proxmox.com> References: <20251029141559.142782-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761747349405 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager 1/1] buildsys: initialize pwt-assets as submodule automatically X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" When the submodule is not initialized there would be some errors at the beginning of the build like: > Error: Can't find stylesheet to import. but then cargo would continue and compile everything only for the build to fail at the very end. Copied from Stoiko's equivalent patch for PMG [0]. [0]: https://lore.proxmox.com/pmg-devel/20251028163628.79739-2-s.ivanov@proxmox.com/ Co-developed-by: Stoiko Ivanov Signed-off-by: Fiona Ebner --- By chance, I stumbled upon Stoiko's patch for PMG after running into the issue myself in PDM :) ui/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/Makefile b/ui/Makefile index 61e5c77..49ae8ee 100644 --- a/ui/Makefile +++ b/ui/Makefile @@ -75,8 +75,11 @@ install: $(COMPILED_OUTPUT) index.hbs install -m0644 dist/material-yew-style.css $(DESTDIR)$(UIDIR) install -m0644 dist/desktop-yew-style.css $(DESTDIR)$(UIDIR) +.PHONY: submodule +submodule: + test -f "pwt-assets/README.md" || git submodule update --init -$(BUILDDIR): +$(BUILDDIR): submodule rm -rf $@ $@.tmp mkdir -p $@.tmp/ui cp -a debian/ src/ pwt-assets/ images/ css/ index.hbs Makefile Cargo.toml $@.tmp/ui -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel