From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 980561FF15E for ; Mon, 13 Oct 2025 10:37:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF7B6DCDC; Mon, 13 Oct 2025 10:38:09 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Mon, 13 Oct 2025 10:33:32 +0200 Message-ID: <20251013083806.1068917-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251013083806.1068917-1-d.csapak@proxmox.com> References: <20251013083806.1068917-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [resources.rs] Subject: [pdm-devel] [PATCH datacenter-manager 1/3] server: api: resources: change use of remote to reference X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" we don't need to take ownership here, and it makes the code easier later. Signed-off-by: Dominik Csapak --- server/src/api/resources.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs index f4f56bcf..39a400c3 100644 --- a/server/src/api/resources.rs +++ b/server/src/api/resources.rs @@ -255,7 +255,7 @@ pub(crate) async fn get_resources_impl( } let filter = filters.clone(); let handle = tokio::spawn(async move { - let (mut resources, error) = match get_resources_for_remote(remote, max_age).await { + let (mut resources, error) = match get_resources_for_remote(&remote, max_age).await { Ok(resources) => (resources, None), Err(error) => { tracing::debug!("failed to get resources from remote - {error:?}"); @@ -700,7 +700,7 @@ static CACHE: LazyLock>> = /// /// If recent enough cached data is available, it is returned /// instead of calling out to the remote. -async fn get_resources_for_remote(remote: Remote, max_age: u64) -> Result, Error> { +async fn get_resources_for_remote(remote: &Remote, max_age: u64) -> Result, Error> { let remote_name = remote.id.to_owned(); if let Some(cached_resource) = get_cached_resources(&remote_name, max_age) { Ok(cached_resource.resources) @@ -756,13 +756,13 @@ fn update_cached_resources(remote: &str, resources: &[Resource], now: i64) { } /// Fetch remote resources and map to pdm-native data types. -async fn fetch_remote_resource(remote: Remote) -> Result, Error> { +async fn fetch_remote_resource(remote: &Remote) -> Result, Error> { let mut resources = Vec::new(); let remote_name = remote.id.to_owned(); match remote.ty { RemoteType::Pve => { - let client = connection::make_pve_client(&remote)?; + let client = connection::make_pve_client(remote)?; let cluster_resources = client.cluster_resources(None).await?; @@ -773,7 +773,7 @@ async fn fetch_remote_resource(remote: Remote) -> Result, Error> { } } RemoteType::Pbs => { - let client = connection::make_pbs_client(&remote)?; + let client = connection::make_pbs_client(remote)?; let status = client.node_status().await?; resources.push(map_pbs_node_status(&remote_name, status)); -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel