From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id F1C671FF15E for ; Mon, 29 Sep 2025 17:48:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16AE416E7B; Mon, 29 Sep 2025 17:49:03 +0200 (CEST) From: Christian Ebner To: pdm-devel@lists.proxmox.com Date: Mon, 29 Sep 2025 17:48:14 +0200 Message-ID: <20250929154820.892720-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759160890033 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager/proxmox 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" This patches fix the ticket parsing when login to instances of PBS version 3 or lower. For this, the current pve_compat flags for `Login` and `Client` are refactored to be an extendable enum variant instead, adding the ticket parsing backwards compatibility. In that compatibility mode, response parsing of the ticket does not interpret the presence of the `ticket-info` field as the ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4 compatible parsing, as the client never used `http-only` tickets. Since this fixes token generation and ACLs setting via the remote add wizard, revert the now outdated warning of PBS v4 minimum requirement. proxmox: Christian Ebner (3): proxmox-login: refactor PVE TFA compat mode proxmox-client: adapt to new compat mode introduced for proxmox-login proxmox-login: add compat mode to fallback to PBS3 ticket parsing proxmox-client/src/client.rs | 12 ++++---- proxmox-client/src/lib.rs | 2 +- proxmox-login/src/lib.rs | 55 +++++++++++++++++++++++++----------- 3 files changed, 45 insertions(+), 24 deletions(-) datacenter-manager: Christian Ebner (3): server: adapt to proxmox-client compat mode changes server: pbs-client: check and fallback to PBS v3 ticket compat mode Revert "ui: add wizard: note that login currently only works for PBS 4" server/src/connection.rs | 43 +++++++++++++++++------------- ui/src/remotes/wizard_page_info.rs | 15 ----------- 2 files changed, 25 insertions(+), 33 deletions(-) Summary over all repositories: 5 files changed, 70 insertions(+), 57 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel