From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6F91D1FF187 for ; Mon, 22 Sep 2025 13:09:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1A29A189D8; Mon, 22 Sep 2025 13:10:17 +0200 (CEST) From: Christian Ebner To: pdm-devel@lists.proxmox.com Date: Mon, 22 Sep 2025 13:09:55 +0200 Message-ID: <20250922110958.369653-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250922110958.369653-1-c.ebner@proxmox.com> References: <20250922110958.369653-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758539402732 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager 3/6] server: api: implement endpoint to scan remote PBS instances X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Provide the analogous api endpoint as for PVE, but since there is no cluster information and only a single host for PBS, limit the implementation to a basic login check using the provided credentials for now. Signed-off-by: Christian Ebner --- server/src/api/pbs/mod.rs | 69 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 65 insertions(+), 4 deletions(-) diff --git a/server/src/api/pbs/mod.rs b/server/src/api/pbs/mod.rs index 0ca97cd..2e203ca 100644 --- a/server/src/api/pbs/mod.rs +++ b/server/src/api/pbs/mod.rs @@ -1,16 +1,17 @@ -use anyhow::Error; +use anyhow::{format_err, Error}; use futures::StreamExt; use proxmox_router::{list_subdirs_api_method, Permission, Router, SubdirMap}; use proxmox_schema::api; +use proxmox_schema::property_string::PropertyString; use proxmox_sortable_macro::sortable; -use pdm_api_types::remotes::{RemoteType, TlsProbeOutcome, REMOTE_ID_SCHEMA}; -use pdm_api_types::{HOST_OPTIONAL_PORT_FORMAT, PRIV_RESOURCE_AUDIT, PRIV_SYS_MODIFY}; +use pdm_api_types::remotes::{NodeUrl, Remote, RemoteType, TlsProbeOutcome, REMOTE_ID_SCHEMA}; +use pdm_api_types::{Authid, HOST_OPTIONAL_PORT_FORMAT, PRIV_RESOURCE_AUDIT, PRIV_SYS_MODIFY}; use crate::{ connection::{self, probe_tls_connection}, - pbs_client::{self, get_remote}, + pbs_client::{self, get_remote, PbsClient}, }; mod rrddata; @@ -22,6 +23,7 @@ pub const ROUTER: Router = Router::new() #[sortable] const SUBDIRS: SubdirMap = &sorted!([ ("remotes", &REMOTES_ROUTER), + ("scan", &Router::new().post(&API_METHOD_SCAN_REMOTE_PBS)), ("probe-tls", &Router::new().post(&API_METHOD_PROBE_TLS)), ]); @@ -146,3 +148,62 @@ async fn probe_tls( ) -> Result { probe_tls_connection(RemoteType::Pbs, hostname, fingerprint).await } + +pub async fn connect_or_login(remote: &Remote) -> Result, Error> { + connection::make_pbs_client_and_login(remote).await +} + +#[api( + input: { + properties: { + hostname: { + type: String, + format: &HOST_OPTIONAL_PORT_FORMAT, + description: "Hostname (with optional port) of the target remote", + }, + fingerprint: { + type: String, + description: "Fingerprint of the target remote.", + optional: true, + }, + "authid": { + type: Authid, + }, + "token": { + type: String, + description: "The token secret or the user password.", + }, + }, + }, + access: { + permission: + &Permission::Privilege(&["/"], PRIV_SYS_MODIFY, false), + }, +)] +/// Scans the given connection info for pbs host information. +/// +/// Checks login using the provided credentials. +pub async fn scan_remote_pbs( + hostname: String, + fingerprint: Option, + authid: Authid, + token: String, +) -> Result { + let remote = Remote { + ty: RemoteType::Pbs, + id: hostname.clone(), + nodes: vec![PropertyString::new(NodeUrl { + hostname, + fingerprint, + })], + authid: authid.clone(), + token, + web_url: None, + }; + + let _client = connect_or_login(&remote) + .await + .map_err(|err| format_err!("could not login: {err}"))?; + + Ok(remote) +} -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel