From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 30D151FF17C for ; Wed, 3 Sep 2025 15:23:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2EA30DDA7; Wed, 3 Sep 2025 15:23:55 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Wed, 3 Sep 2025 15:09:16 +0200 Message-ID: <20250903132351.841830-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [resource.rs, mod.rs, lib.rs, resources.rs, main.rs] Subject: [pdm-devel] [PATCH datacenter-manager v5 00/10] implement more complex search syntax X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" this introduces a more complex search syntax for the resources api call and uses that with the dashboard to show relevant resources, e.g. when clicking on the remotes panel when there are failed remotes, it adds a search to the box that filters for offline remotes. Same for clicking on the running vm count, etc. The syntax is a first draft of mine, we can still tweak and change it as we see fit, but it's a start. a 'normal' search term gets filtered to id/name so that does not change as before, but you can now specify 'categories' with `category:value` e.g. it's now possible to search for `type:remote` or `status:offline` it also adds the possibility to mark terms as required like this: +someterm required terms have to exist in the resulting resource, while optional ones are OR'd (so at least one optional match must exist) Not implemented yet are (but can be done afterwards): * GUI for filtering * Include subscription status * negation of terms (this get's complicated fast ;) ) changes from v4: * integrated suggestions from wolfgang and shannon (see specific patches for details) * made SearchTerm always parse from &str, so an empty string as well as things like ":foo", "foo:" and "+" are valid searchterms now (even if they can't find anything at the moment) * added more useful searches to the node panel (added a status when e.g. nodes are offline or unknown) changes from v3: * use 'starts_with' for type/status filtering * add missing doc comments * add more tests * refactor guest panel in dashboard to use `List` * add icon in guest panel for discoverability changes from v2: * incorporated stefans feedback for FromIterator, Default, etc. * added tests for the 'matches' function * add required search term for the guest 'All' text changes from v1: * added commit to improve text width * added commit to add clear trigger to search box * rebased on master Dominik Csapak (10): pdm-api-types: resources: add helper methods for fields lib: add pdm-search crate server: api: resources: add more complex filter syntax ui: add possibility to insert into search box ui: dashboard: remotes panel: open search on click ui: dashboard: guest panel: search for guest states when clicking on them ui: dashboard: search for nodes when clicking on the nodes panel ui: search box: add clear trigger ui: dashboard: guest panel: use `List` instead of `DataTable` ui: dashboard: guest panel: add search icon for better discoverability Cargo.toml | 2 + lib/pdm-api-types/src/resource.rs | 72 ++++++++ lib/pdm-search/Cargo.toml | 9 + lib/pdm-search/src/lib.rs | 267 ++++++++++++++++++++++++++++++ server/Cargo.toml | 1 + server/src/api/resources.rs | 229 +++++++++++++++++++++++-- ui/Cargo.toml | 1 + ui/src/dashboard/guest_panel.rs | 210 +++++++++++++---------- ui/src/dashboard/mod.rs | 63 +++++-- ui/src/dashboard/remote_panel.rs | 30 +++- ui/src/lib.rs | 3 + ui/src/main.rs | 17 +- ui/src/pve/mod.rs | 21 ++- ui/src/search_provider.rs | 35 ++++ ui/src/widget/search_box.rs | 40 ++++- 15 files changed, 877 insertions(+), 123 deletions(-) create mode 100644 lib/pdm-search/Cargo.toml create mode 100644 lib/pdm-search/src/lib.rs create mode 100644 ui/src/search_provider.rs -- 2.47.2 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel