From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A3B6A1FF186 for ; Fri, 29 Aug 2025 14:33:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE2B62DDE6; Fri, 29 Aug 2025 14:34:04 +0200 (CEST) From: Stefan Hanreich To: pdm-devel@lists.proxmox.com Date: Fri, 29 Aug 2025 14:33:29 +0200 Message-ID: <20250829123330.184123-3-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250829123330.184123-1-s.hanreich@proxmox.com> References: <20250829123330.184123-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.192 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 2/2] server: parallel fetcher: refactor: use helpers for common operations X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" The introduction of the helper that executes the callback once per remote factored out some common functionality from existing helpers. Adapt the existing helper that queries all nodes to also use those helpers to avoid duplicated code. No functional changes intended. Signed-off-by: Stefan Hanreich --- server/src/parallel_fetcher.rs | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/server/src/parallel_fetcher.rs b/server/src/parallel_fetcher.rs index e55cc25..5f6a317 100644 --- a/server/src/parallel_fetcher.rs +++ b/server/src/parallel_fetcher.rs @@ -223,16 +223,7 @@ impl ParallelFetcher { match remote.ty { RemoteType::Pve => { - let remote_clone = remote.clone(); - - let nodes = match async move { - let client = connection::make_pve_client(&remote_clone)?; - let nodes = client.list_nodes().await?; - - Ok::, Error>(nodes) - } - .await - { + let nodes = match Self::fetch_pve_node_list(&remote).await { Ok(nodes) => nodes, Err(err) => return (remote.id.clone(), Err(err)), }; -- 2.47.2 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel