From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 506881FF15C for ; Fri, 22 Aug 2025 10:54:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 09E2BB72D; Fri, 22 Aug 2025 10:54:53 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Fri, 22 Aug 2025 10:32:39 +0200 Message-ID: <20250822085409.1139639-22-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250822085409.1139639-1-d.csapak@proxmox.com> References: <20250822085409.1139639-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager v4 21/23] ui: pve wizard: connect: reset later pages when form changes X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" not on connect. With this, we don't reset the later pages anymore when we change between tabs without changing anything. The first connetion check will now only be done on the first navigation away from the page or when the form changed afterwards. Same for the 'Settings' panel. Only on the first change from 'Settings' to 'Endpoints' or when the settings change will the endpoint list be updated. Signed-off-by: Dominik Csapak --- ui/src/remotes/wizard_page_connect.rs | 8 +++++--- ui/src/remotes/wizard_page_info.rs | 15 ++++++++++----- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/ui/src/remotes/wizard_page_connect.rs b/ui/src/remotes/wizard_page_connect.rs index d5d9708..6d48264 100644 --- a/ui/src/remotes/wizard_page_connect.rs +++ b/ui/src/remotes/wizard_page_connect.rs @@ -145,6 +145,11 @@ impl Component for PdmWizardPageConnect { } } props.info.page_lock(!self.form_valid); + for page in ["nodes", "info"] { + if let Some(form_ctx) = props.info.lookup_form_context(&Key::from(page)) { + form_ctx.write().reset_form(); + } + } } Msg::Connect => { let link = ctx.link().clone(); @@ -170,9 +175,6 @@ impl Component for PdmWizardPageConnect { } } - if let Some(form_ctx) = props.info.lookup_form_context(&Key::from("nodes")) { - form_ctx.write().reset_form(); - } props.info.reset_remaining_valid_pages(); if self.connect_info.is_some() { props.info.go_to_next_page(); diff --git a/ui/src/remotes/wizard_page_info.rs b/ui/src/remotes/wizard_page_info.rs index 0d77144..88c6463 100644 --- a/ui/src/remotes/wizard_page_info.rs +++ b/ui/src/remotes/wizard_page_info.rs @@ -214,9 +214,19 @@ impl Component for PdmWizardPageInfo { } else { self.credentials = None; } + if let Some(form_ctx) = props.info.lookup_form_context(&Key::from("nodes")) { + let mut form = form_ctx.write(); + form.set_field_value("nodes", serde_json::Value::Null); + form.reset_form(); + } props.info.page_lock(self.credentials.is_none()); } Msg::Connect => { + if self.server_info.is_some() { + props.info.page_lock(false); + props.info.go_to_next_page(); + return true; + } let link = ctx.link().clone(); self.update_server_info(ctx, None); let form_ctx = props.info.form_ctx.clone(); @@ -246,11 +256,6 @@ impl Component for PdmWizardPageInfo { } } - if let Some(form_ctx) = props.info.lookup_form_context(&Key::from("nodes")) { - let mut form = form_ctx.write(); - form.set_field_value("nodes", serde_json::Value::Null); - form.reset_form(); - } props.info.reset_remaining_valid_pages(); if self.last_error.is_none() { -- 2.47.2 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel