From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1CE201FF17C for ; Wed, 20 Aug 2025 14:42:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13E07A779; Wed, 20 Aug 2025 14:43:49 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Date: Wed, 20 Aug 2025 14:43:29 +0200 Message-ID: <20250820124329.220124-8-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250820124329.220124-1-l.wagner@proxmox.com> References: <20250820124329.220124-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755693780746 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v7 7/7] remote tasks: log error in case of task panic, instead of cancelling all tasks X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Should hopefully never happen, but for cases like these we still want to to persist the tasks from other nodes instead of failing completely. Also remove the `set_node_failure` function for NodeFetchSuccessMap. For panic'd tasks we don't have a straightforward way to get the node name, and we only ever check for success any way, not failure. Suggested-by: Dominik Csapak Signed-off-by: Lukas Wagner --- Notes: New in v7. server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs | 5 +++-- server/src/remote_tasks/task_cache.rs | 5 ----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs b/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs index 4701a935..04c51dac 100644 --- a/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs +++ b/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs @@ -411,10 +411,11 @@ async fn fetch_tasks( } Err(error) => { log::error!("could not fetch tasks: {error:#}"); - node_results.set_node_failure(remote.id.clone(), node_name); } }, - Err(err) => return Err(err.into()), + Err(error) => { + log::error!("could not join task fetching task: {error:#}"); + } } } } diff --git a/server/src/remote_tasks/task_cache.rs b/server/src/remote_tasks/task_cache.rs index 1afeaee4..e9e708e4 100644 --- a/server/src/remote_tasks/task_cache.rs +++ b/server/src/remote_tasks/task_cache.rs @@ -188,11 +188,6 @@ impl NodeFetchSuccessMap { self.0.insert((remote, node), true); } - /// Mark a node of a given remote as failed. - pub fn set_node_failure(&mut self, remote: String, node: String) { - self.0.insert((remote, node), false); - } - /// Returns whether tasks from a given node of a remote were successfully fetched. pub fn node_successful(&self, remote: &str, node: &str) -> bool { matches!(self.0.get(&(remote.into(), node.into())), Some(true)) -- 2.47.2 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel