From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 73DC51FF165 for ; Thu, 14 Aug 2025 15:30:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D24EE1362D; Thu, 14 Aug 2025 15:32:34 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Date: Thu, 14 Aug 2025 15:31:37 +0200 Message-ID: <20250814133142.386650-19-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250814133142.386650-1-l.wagner@proxmox.com> References: <20250814133142.386650-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755178277632 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.128 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v5 18/23] api: metric-collection: add status endpoint X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" This adds a new API endpoint at /metric-collection/status, returning the status of the last metric collection attempt from each remote. For now, this contains the timestamp (last-collected) and any error that occurred (error). Signed-off-by: Lukas Wagner Reviewed-by: Maximiliano Sandoval --- Notes: Changes since v2: - use `_` for type casts - Drop max-concurrency, and delay settings for now lib/pdm-api-types/src/lib.rs | 3 +++ lib/pdm-api-types/src/metric_collection.rs | 20 ++++++++++++++++++++ server/src/api/metric_collection.rs | 16 +++++++++++++++- server/src/metric_collection/mod.rs | 22 ++++++++++++++++++++++ 4 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 lib/pdm-api-types/src/metric_collection.rs diff --git a/lib/pdm-api-types/src/lib.rs b/lib/pdm-api-types/src/lib.rs index 38449071..6115e41c 100644 --- a/lib/pdm-api-types/src/lib.rs +++ b/lib/pdm-api-types/src/lib.rs @@ -19,6 +19,9 @@ pub use acl::*; mod node_config; pub use node_config::*; +mod metric_collection; +pub use metric_collection::*; + mod proxy; pub use proxy::HTTP_PROXY_SCHEMA; diff --git a/lib/pdm-api-types/src/metric_collection.rs b/lib/pdm-api-types/src/metric_collection.rs new file mode 100644 index 00000000..5279c8a4 --- /dev/null +++ b/lib/pdm-api-types/src/metric_collection.rs @@ -0,0 +1,20 @@ +//! API types for metric collection. + +use serde::{Deserialize, Serialize}; + +use proxmox_schema::api; + +#[api] +#[derive(Clone, Deserialize, Serialize)] +#[serde(rename_all = "kebab-case")] +/// Per-remote collection status. +pub struct MetricCollectionStatus { + /// The remote's name. + pub remote: String, + /// Any error that occured during the last collection attempt. + #[serde(skip_serializing_if = "Option::is_none")] + pub error: Option, + /// Timestamp of last successful collection. + #[serde(skip_serializing_if = "Option::is_none")] + pub last_collection: Option, +} diff --git a/server/src/api/metric_collection.rs b/server/src/api/metric_collection.rs index 22736cb0..a8243296 100644 --- a/server/src/api/metric_collection.rs +++ b/server/src/api/metric_collection.rs @@ -5,7 +5,11 @@ use proxmox_rrd_api_types::{RrdMode, RrdTimeframe}; use proxmox_schema::api; use proxmox_sortable_macro::sortable; -use pdm_api_types::{remotes::REMOTE_ID_SCHEMA, rrddata::FullCollectionDatapoint}; +use pdm_api_types::{ + remotes::REMOTE_ID_SCHEMA, rrddata::FullCollectionDatapoint, MetricCollectionStatus, +}; + +use crate::metric_collection; use super::rrd_common::{self, DataPoint}; @@ -21,6 +25,10 @@ const SUBDIRS: SubdirMap = &sorted!([ "rrddata", &Router::new().get(&API_METHOD_GET_METRIC_COLLECTION_RRD_DATA) ), + ( + "status", + &Router::new().get(&API_METHOD_GET_METRIC_COLLECTION_STATUS) + ), ]); #[api( @@ -83,3 +91,9 @@ fn get_metric_collection_rrd_data( let base = "local/metric-collection"; rrd_common::create_datapoints_from_rrd(base, timeframe, cf) } + +#[api] +/// Read metric collection RRD data. +fn get_metric_collection_status() -> Result, Error> { + metric_collection::get_status() +} diff --git a/server/src/metric_collection/mod.rs b/server/src/metric_collection/mod.rs index 5b6c14d2..9f832ded 100644 --- a/server/src/metric_collection/mod.rs +++ b/server/src/metric_collection/mod.rs @@ -7,6 +7,8 @@ use tokio::sync::mpsc::{self, Sender}; use proxmox_sys::fs::CreateOptions; +use pdm_api_types::MetricCollectionStatus; + mod collection_task; pub mod rrd_cache; mod rrd_task; @@ -87,3 +89,23 @@ pub async fn trigger_metric_collection() -> Result<(), Error> { Ok(()) } + +/// Get each remote's metric collection status. +pub fn get_status() -> Result, Error> { + let (remotes, _) = pdm_config::remotes::config()?; + let state = collection_task::load_state()?; + + let mut result = Vec::new(); + + for (remote, _) in remotes.into_iter() { + if let Some(status) = state.get_status(&remote) { + result.push(MetricCollectionStatus { + remote, + error: status.error.clone(), + last_collection: status.last_collection, + }) + } + } + + Ok(result) +} -- 2.47.2 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel