From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id A99091FF164
for <inbox@lore.proxmox.com>; Fri, 6 Jun 2025 09:27:32 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A961D35751;
Fri, 6 Jun 2025 09:27:53 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Date: Fri, 6 Jun 2025 09:27:18 +0200
Message-Id: <20250606072720.664054-4-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250606072720.664054-1-d.csapak@proxmox.com>
References: <20250606072720.664054-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pdm-devel] [PATCH datacenter-manager 2/4] ui: dashboard: introduce
DashboardConfig
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
to hold the configuration of the dashboard. We'll later use this to
hold the user configuration.
Having it as a property does not make sense here since we don't set it
from outside the dashboard, and since it's not a generic component,
it's not likely to be reused elsewhere.
Saving it as a PersistentState also makes it possible to have it persist
across sessions when we're able to change it.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/dashboard/mod.rs | 25 +++++++++++++++++++------
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/ui/src/dashboard/mod.rs b/ui/src/dashboard/mod.rs
index 0832ced..960766e 100644
--- a/ui/src/dashboard/mod.rs
+++ b/ui/src/dashboard/mod.rs
@@ -1,6 +1,7 @@
use std::rc::Rc;
use anyhow::Error;
+use serde::{Deserialize, Serialize};
use serde_json::json;
use yew::{
virtual_dom::{VComp, VNode},
@@ -11,6 +12,8 @@ use proxmox_yew_comp::{http_get, Status};
use pwt::{
css::{AlignItems, FlexDirection, FlexFit, FlexWrap, JustifyContent},
prelude::*,
+ props::StorageLocation,
+ state::PersistentState,
widget::{error_message, Button, Column, Container, Fa, Panel, Row},
AsyncPool,
};
@@ -32,12 +35,11 @@ use remote_panel::RemotePanel;
mod guest_panel;
use guest_panel::GuestPanel;
+/// The default 'max-age' parameter in seconds.
+pub const DEFAULT_MAX_AGE_S: u64 = 60;
+
#[derive(Properties, PartialEq)]
-pub struct Dashboard {
- #[prop_or(60)]
- /// The time (in seconds) to not refresh cached data. (Default: 60)
- max_age_seconds: u64,
-}
+pub struct Dashboard {}
impl Dashboard {
pub fn new() -> Self {
@@ -51,6 +53,13 @@ impl Default for Dashboard {
}
}
+#[derive(Serialize, Deserialize, Default, Debug)]
+#[serde(rename_all = "kebab-case")]
+pub struct DashboardConfig {
+ #[serde(skip_serializing_if = "Option::is_none")]
+ max_age: Option<u64>,
+}
+
pub enum Msg {
LoadingFinished(Result<ResourcesStatus, Error>),
TopEntitiesLoadResult(Result<pdm_client::types::TopEntities, proxmox_client::Error>),
@@ -68,6 +77,7 @@ pub struct PdmDashboard {
show_wizard: bool,
_context_listener: ContextHandle<RemoteList>,
_async_pool: AsyncPool,
+ _config: PersistentState<DashboardConfig>,
}
impl PdmDashboard {
@@ -169,7 +179,9 @@ impl Component for PdmDashboard {
fn create(ctx: &yew::Context<Self>) -> Self {
let link = ctx.link().clone();
- let max_age = ctx.props().max_age_seconds;
+ let _config: PersistentState<DashboardConfig> =
+ PersistentState::new(StorageLocation::local("dashboard-config"));
+ let max_age = _config.max_age.unwrap_or(DEFAULT_MAX_AGE_S);
let async_pool = AsyncPool::new();
@@ -199,6 +211,7 @@ impl Component for PdmDashboard {
show_wizard: false,
_context_listener,
_async_pool: async_pool,
+ _config,
}
}
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel