From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 7C4C61FF15E
for <inbox@lore.proxmox.com>; Tue, 28 Jan 2025 13:26:27 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id AC45FCE88;
Tue, 28 Jan 2025 13:26:25 +0100 (CET)
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Date: Tue, 28 Jan 2025 13:25:20 +0100
Message-Id: <20250128122520.167796-16-l.wagner@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250128122520.167796-1-l.wagner@proxmox.com>
References: <20250128122520.167796-1-l.wagner@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.015 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 15/15] remote-tasks:
restrict function visibility
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
These fuctions are never called from any other module, so we can
make them private.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
server/src/remote_tasks/mod.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/src/remote_tasks/mod.rs b/server/src/remote_tasks/mod.rs
index 5735f2f..49789c9 100644
--- a/server/src/remote_tasks/mod.rs
+++ b/server/src/remote_tasks/mod.rs
@@ -331,7 +331,7 @@ pub fn track_running_task(task: RemoteUpid) -> Option<JoinHandle<()>> {
/// Get a list of running foreign tasks
///
/// panics on a poisoned mutex
-pub fn get_running_tasks() -> Vec<RemoteUpid> {
+fn get_running_tasks() -> Vec<RemoteUpid> {
RUNNING_FOREIGN_TASKS
.read()
.unwrap()
@@ -344,7 +344,7 @@ pub fn get_running_tasks() -> Vec<RemoteUpid> {
/// returns their upids + status
///
/// panics on a poisoned mutex
-pub async fn get_finished_tasks() -> Vec<(RemoteUpid, String)> {
+async fn get_finished_tasks() -> Vec<(RemoteUpid, String)> {
let mut finished = Vec::new();
let config = match pdm_config::remotes::config() {
Ok((config, _)) => config,
@@ -396,7 +396,7 @@ pub async fn get_finished_tasks() -> Vec<(RemoteUpid, String)> {
}
/// Parses a task status string into a TaskStateType
-pub fn tasktype(status: &str) -> TaskStateType {
+fn tasktype(status: &str) -> TaskStateType {
if status == "unknown" || status.is_empty() {
TaskStateType::Unknown
} else if status == "OK" {
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel