[pdm-devel] [PATCH proxmox-datacenter-manager 13/15] task cache: tests: improve test coverage

[Lukas Wagner <l.wagner@proxmox.com>]

Adds some further trivial checks to improve coverage.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 server/src/remote_tasks/task_cache.rs | 40 +++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/server/src/remote_tasks/task_cache.rs b/server/src/remote_tasks/task_cache.rs
index e08e3d4..49164cb 100644
--- a/server/src/remote_tasks/task_cache.rs
+++ b/server/src/remote_tasks/task_cache.rs
@@ -289,6 +289,13 @@ mod tests {
         tasks.reverse();
         assert_eq!(tasks, res);
 
+        assert_eq!(cache.get_last_fetched("some-remote"), Some(0));
+        assert_eq!(cache.get_most_recent_starttime("some-remote").unwrap(), now);
+
+        assert!(cache.get_tasks("other-remote").is_none());
+        assert!(cache.get_last_fetched("other-remote").is_none());
+        assert!(cache.get_most_recent_starttime("other-remote").is_none());
+
         Ok(())
     }
 
@@ -322,4 +329,37 @@ mod tests {
 
         Ok(())
     }
+
+    #[test]
+    fn merge_tasks_2() -> Result<(), Error> {
+        // Pretty much identical to the other test, but try
+        // to trigger different edge-cases in the merge iterator.
+
+        // Arrange
+        let mut a = Vec::new();
+        for i in [30, 10, 20, 5] {
+            a.push(make_upid(i, None, None)?);
+        }
+
+        let mut b = Vec::new();
+        for i in [25, 15] {
+            b.push(make_upid(i, None, None)?);
+        }
+        a.push(make_upid(40, Some(50), Some("some status".into()))?);
+        b.push(make_upid(40, None, None)?);
+
+        // Act
+        let tasks = TaskCache::merge_tasks(a, b, 6);
+
+        // Assert
+        assert_eq!(tasks.len(), 6);
+        assert_eq!(tasks[0].starttime, 40);
+        assert_eq!(tasks[1].starttime, 30);
+        assert_eq!(tasks[2].starttime, 25);
+        assert_eq!(tasks[3].starttime, 20);
+        assert_eq!(tasks[4].starttime, 15);
+        assert_eq!(tasks[5].starttime, 10);
+
+        Ok(())
+    }
 }
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel