From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 305F61FF16B
for <inbox@lore.proxmox.com>; Thu, 23 Jan 2025 15:41:42 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 66995E991;
Thu, 23 Jan 2025 15:41:38 +0100 (CET)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Date: Thu, 23 Jan 2025 15:41:03 +0100
Message-Id: <20250123144104.3849889-2-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250123144104.3849889-1-d.csapak@proxmox.com>
References: <20250123144104.3849889-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.020 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pdm-devel] [PATCH datacenter-manager 1/2] ui: remote selector:
update remotes when context changes
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
we have to save the ContextHandle + react in the callback to changes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/widget/remote_selector.rs | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/ui/src/widget/remote_selector.rs b/ui/src/widget/remote_selector.rs
index 80e434c..8fae902 100644
--- a/ui/src/widget/remote_selector.rs
+++ b/ui/src/widget/remote_selector.rs
@@ -3,7 +3,7 @@ use std::rc::Rc;
use wasm_bindgen::UnwrapThrowExt;
use yew::{
html::{IntoEventCallback, IntoPropValue},
- AttrValue, Callback, Component, Properties,
+ AttrValue, Callback, Component, ContextHandle, Properties,
};
use pdm_api_types::remotes::RemoteType;
@@ -43,17 +43,22 @@ impl RemoteSelector {
pub struct PdmRemoteSelector {
remotes: Rc<Vec<AttrValue>>,
+ _remotes_update_ctx: Option<ContextHandle<RemoteList>>,
}
impl PdmRemoteSelector {
fn update_remote_list(&mut self, ctx: &yew::Context<Self>) {
- let (remotes, _): (RemoteList, _) = ctx
+ let (remotes, _remotes_update_ctx): (RemoteList, _) = ctx
.link()
- .context(ctx.link().callback(|_| ()))
+ .context(ctx.link().callback(|list| list))
.unwrap_throw();
- let ty = ctx.props().remote_type;
+ self.set_remote_list(ctx, remotes);
+ self._remotes_update_ctx = Some(_remotes_update_ctx);
+ }
+ fn set_remote_list(&mut self, ctx: &yew::Context<Self>, remotes: RemoteList) {
+ let ty = ctx.props().remote_type;
let remotes = remotes
.iter()
.filter_map(move |remote| match (ty, remote.ty) {
@@ -68,18 +73,24 @@ impl PdmRemoteSelector {
}
impl Component for PdmRemoteSelector {
- type Message = ();
+ type Message = RemoteList;
type Properties = RemoteSelector;
fn create(ctx: &yew::Context<Self>) -> Self {
let mut this = Self {
remotes: Rc::new(Vec::new()),
+ _remotes_update_ctx: None,
};
this.update_remote_list(ctx);
this
}
+ fn update(&mut self, ctx: &yew::Context<Self>, msg: Self::Message) -> bool {
+ self.set_remote_list(ctx, msg);
+ true
+ }
+
fn changed(&mut self, ctx: &yew::Context<Self>, _old_props: &Self::Properties) -> bool {
if ctx.props().remote_type != _old_props.remote_type {
self.update_remote_list(ctx);
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel