From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 1/2] ui: remote selector: update remotes when context changes
Date: Thu, 23 Jan 2025 15:41:03 +0100 [thread overview]
Message-ID: <20250123144104.3849889-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250123144104.3849889-1-d.csapak@proxmox.com>
we have to save the ContextHandle + react in the callback to changes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/widget/remote_selector.rs | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/ui/src/widget/remote_selector.rs b/ui/src/widget/remote_selector.rs
index 80e434c..8fae902 100644
--- a/ui/src/widget/remote_selector.rs
+++ b/ui/src/widget/remote_selector.rs
@@ -3,7 +3,7 @@ use std::rc::Rc;
use wasm_bindgen::UnwrapThrowExt;
use yew::{
html::{IntoEventCallback, IntoPropValue},
- AttrValue, Callback, Component, Properties,
+ AttrValue, Callback, Component, ContextHandle, Properties,
};
use pdm_api_types::remotes::RemoteType;
@@ -43,17 +43,22 @@ impl RemoteSelector {
pub struct PdmRemoteSelector {
remotes: Rc<Vec<AttrValue>>,
+ _remotes_update_ctx: Option<ContextHandle<RemoteList>>,
}
impl PdmRemoteSelector {
fn update_remote_list(&mut self, ctx: &yew::Context<Self>) {
- let (remotes, _): (RemoteList, _) = ctx
+ let (remotes, _remotes_update_ctx): (RemoteList, _) = ctx
.link()
- .context(ctx.link().callback(|_| ()))
+ .context(ctx.link().callback(|list| list))
.unwrap_throw();
- let ty = ctx.props().remote_type;
+ self.set_remote_list(ctx, remotes);
+ self._remotes_update_ctx = Some(_remotes_update_ctx);
+ }
+ fn set_remote_list(&mut self, ctx: &yew::Context<Self>, remotes: RemoteList) {
+ let ty = ctx.props().remote_type;
let remotes = remotes
.iter()
.filter_map(move |remote| match (ty, remote.ty) {
@@ -68,18 +73,24 @@ impl PdmRemoteSelector {
}
impl Component for PdmRemoteSelector {
- type Message = ();
+ type Message = RemoteList;
type Properties = RemoteSelector;
fn create(ctx: &yew::Context<Self>) -> Self {
let mut this = Self {
remotes: Rc::new(Vec::new()),
+ _remotes_update_ctx: None,
};
this.update_remote_list(ctx);
this
}
+ fn update(&mut self, ctx: &yew::Context<Self>, msg: Self::Message) -> bool {
+ self.set_remote_list(ctx, msg);
+ true
+ }
+
fn changed(&mut self, ctx: &yew::Context<Self>, _old_props: &Self::Properties) -> bool {
if ctx.props().remote_type != _old_props.remote_type {
self.update_remote_list(ctx);
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-01-23 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 14:41 [pdm-devel] [PATCH yew-comp] tasks: make column sizes a bit more dynamic Dominik Csapak
2025-01-23 14:41 ` Dominik Csapak [this message]
2025-01-23 14:41 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: remote " Dominik Csapak
2025-01-28 15:18 ` [pdm-devel] applied: [PATCH yew-comp] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250123144104.3849889-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox