public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH proxmox-datacenter-manager 1/2] mark missing translatable strings as such
@ 2025-01-22 13:51 Maximiliano Sandoval
  2025-01-22 13:51 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/2] do not split translatable strings Maximiliano Sandoval
  2025-01-22 16:06 ` [pdm-devel] applied-series: [PATCH proxmox-datacenter-manager 1/2] mark missing translatable strings as such Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2025-01-22 13:51 UTC (permalink / raw)
  To: pdm-devel

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 ui/src/administration/mod.rs |  8 ++++----
 ui/src/certificates.rs       | 11 +++++++----
 ui/src/configuration/mod.rs  |  2 +-
 ui/src/remotes/mod.rs        |  4 ++--
 4 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/ui/src/administration/mod.rs b/ui/src/administration/mod.rs
index 2c9a2b6..38411a9 100644
--- a/ui/src/administration/mod.rs
+++ b/ui/src/administration/mod.rs
@@ -70,7 +70,7 @@ impl Component for PdmServerAdministration {
             .with_item_builder(
                 TabBarItem::new()
                     .key("updates")
-                    .label("Updates")
+                    .label(tr!("Updates"))
                     .icon_class("fa fa-refresh"),
                 move |_| {
                     Container::new()
@@ -83,7 +83,7 @@ impl Component for PdmServerAdministration {
             .with_item_builder(
                 TabBarItem::new()
                     .key("repositories")
-                    .label("Repositories")
+                    .label(tr!("Repositories"))
                     .icon_class("fa fa-files-o"),
                 |_| {
                     Container::new()
@@ -96,7 +96,7 @@ impl Component for PdmServerAdministration {
             .with_item_builder(
                 TabBarItem::new()
                     .key("syslog")
-                    .label("Syslog")
+                    .label(tr!("Syslog"))
                     .icon_class("fa fa-list"),
                 |_| {
                     Container::new()
@@ -109,7 +109,7 @@ impl Component for PdmServerAdministration {
             .with_item_builder(
                 TabBarItem::new()
                     .key("tasks")
-                    .label("Tasks")
+                    .label(tr!("Tasks"))
                     .icon_class("fa fa-list-alt"),
                 |_| {
                     Container::new()
diff --git a/ui/src/certificates.rs b/ui/src/certificates.rs
index bd7629f..cd1a470 100644
--- a/ui/src/certificates.rs
+++ b/ui/src/certificates.rs
@@ -18,7 +18,7 @@ pub fn certificates_panel() -> Html {
         .with_item_builder(
             TabBarItem::new()
                 .key("certificate_List")
-                .label("Certificates"),
+                .label(tr!("Certificates")),
             |_| {
                 Container::new()
                     .class("pwt-content-spacer")
@@ -28,7 +28,10 @@ pub fn certificates_panel() -> Html {
             },
         )
         .with_item_builder(
-            TabBarItem::new().key("acme_domains").label("ACME Domains"),
+            TabBarItem::new()
+                .key("acme_domains")
+                // TRANSLATORS: ACME Stands for Automatic Certificate Management Environment
+                .label(tr!("ACME Domains")),
             |_| {
                 Container::new()
                     .class("pwt-content-spacer")
@@ -40,7 +43,7 @@ pub fn certificates_panel() -> Html {
         .with_item_builder(
             TabBarItem::new()
                 .key("acme_accounts")
-                .label("ACME Accounts"),
+                .label(tr!("ACME Accounts")),
             |_| {
                 Container::new()
                     .class("pwt-content-spacer")
@@ -52,7 +55,7 @@ pub fn certificates_panel() -> Html {
         .with_item_builder(
             TabBarItem::new()
                 .key("acme_plugins")
-                .label("Challenge Plugins"),
+                .label(tr!("Challenge Plugins")),
             |_| {
                 Container::new()
                     .class("pwt-content-spacer")
diff --git a/ui/src/configuration/mod.rs b/ui/src/configuration/mod.rs
index 25cd306..5ec3fe0 100644
--- a/ui/src/configuration/mod.rs
+++ b/ui/src/configuration/mod.rs
@@ -29,7 +29,7 @@ pub fn system_configuration() -> Html {
         .with_item_builder(
             TabBarItem::new()
                 .key("webauthn")
-                .label("WebAuthn TFA")
+                .label(tr!("WebAuthn TFA"))
                 .icon_class("fa fa-sliders"),
             |_| html! { <WebauthnPanel/> },
         );
diff --git a/ui/src/remotes/mod.rs b/ui/src/remotes/mod.rs
index a2f471c..fb2c5e4 100644
--- a/ui/src/remotes/mod.rs
+++ b/ui/src/remotes/mod.rs
@@ -41,14 +41,14 @@ pub fn system_configuration() -> Html {
         .with_item_builder(
             TabBarItem::new()
                 .key("configuration")
-                .label("Configuration")
+                .label(tr!("Configuration"))
                 .icon_class("fa fa-cogs"),
             |_| RemoteConfigPanel::new().into(),
         )
         .with_item_builder(
             TabBarItem::new()
                 .key("tasks")
-                .label("Tasks")
+                .label(tr!("Tasks"))
                 .icon_class("fa fa-book"),
             |_| tasks::RemoteTaskList::new().into(),
         );
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pdm-devel] [PATCH proxmox-datacenter-manager 2/2] do not split translatable strings
  2025-01-22 13:51 [pdm-devel] [PATCH proxmox-datacenter-manager 1/2] mark missing translatable strings as such Maximiliano Sandoval
@ 2025-01-22 13:51 ` Maximiliano Sandoval
  2025-01-22 16:06 ` [pdm-devel] applied-series: [PATCH proxmox-datacenter-manager 1/2] mark missing translatable strings as such Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2025-01-22 13:51 UTC (permalink / raw)
  To: pdm-devel

This removes contexts for translators. Instead add a comment so it is
clean the context.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 ui/src/configuration/mod.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ui/src/configuration/mod.rs b/ui/src/configuration/mod.rs
index 5ec3fe0..ca16685 100644
--- a/ui/src/configuration/mod.rs
+++ b/ui/src/configuration/mod.rs
@@ -22,7 +22,8 @@ pub fn system_configuration() -> Html {
         .with_item_builder(
             TabBarItem::new()
                 .key("network")
-                .label(tr!("Network") + "/" + &tr!("Time"))
+                // TRANSLATORS: As in "Network and Time system configuration"
+                .label(tr!("Network/Time"))
                 .icon_class("fa fa-exchange"),
             |_| html! { <NetworkTimePanel/> },
         )
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pdm-devel] applied-series: [PATCH proxmox-datacenter-manager 1/2] mark missing translatable strings as such
  2025-01-22 13:51 [pdm-devel] [PATCH proxmox-datacenter-manager 1/2] mark missing translatable strings as such Maximiliano Sandoval
  2025-01-22 13:51 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/2] do not split translatable strings Maximiliano Sandoval
@ 2025-01-22 16:06 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-01-22 16:06 UTC (permalink / raw)
  To: Proxmox Datacenter Manager development discussion, Maximiliano Sandoval

Am 22.01.25 um 14:51 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  ui/src/administration/mod.rs |  8 ++++----
>  ui/src/certificates.rs       | 11 +++++++----
>  ui/src/configuration/mod.rs  |  2 +-
>  ui/src/remotes/mod.rs        |  4 ++--
>  4 files changed, 14 insertions(+), 11 deletions(-)
> 
>

applied both patches, thanks!


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-01-22 16:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-22 13:51 [pdm-devel] [PATCH proxmox-datacenter-manager 1/2] mark missing translatable strings as such Maximiliano Sandoval
2025-01-22 13:51 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/2] do not split translatable strings Maximiliano Sandoval
2025-01-22 16:06 ` [pdm-devel] applied-series: [PATCH proxmox-datacenter-manager 1/2] mark missing translatable strings as such Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal