From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5E4281FF16E for ; Mon, 20 Jan 2025 10:30:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3522516290; Mon, 20 Jan 2025 10:30:43 +0100 (CET) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Mon, 20 Jan 2025 10:29:59 +0100 Message-Id: <20250120093006.927014-10-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250120093006.927014-1-d.csapak@proxmox.com> References: <20250120093006.927014-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager 2/9] server: task cache: skip remotes with errors on fetch X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" instead of failing the whole cache retrieval, just skip the remote. Signed-off-by: Dominik Csapak --- server/src/task_cache.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/server/src/task_cache.rs b/server/src/task_cache.rs index 3ef24b1..210aa5f 100644 --- a/server/src/task_cache.rs +++ b/server/src/task_cache.rs @@ -42,7 +42,13 @@ pub async fn get_tasks(max_age: i64) -> Result, Error> { // Data in cache is recent enough and has not been invalidated. all_tasks.extend(tasks); } else { - let tasks = fetch_tasks(remote).await?; + let tasks = match fetch_tasks(remote).await { + Ok(tasks) => tasks, + Err(err) => { + // ignore errors for not reachable remotes + continue; + } + }; cache.set_tasks(remote_name.as_str(), tasks.clone(), now); all_tasks.extend(tasks); -- 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel