From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 67CD01FF173
for <inbox@lore.proxmox.com>; Mon, 13 Jan 2025 15:28:23 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id CC41C1567;
Mon, 13 Jan 2025 15:28:02 +0100 (CET)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Date: Mon, 13 Jan 2025 15:27:16 +0100
Message-Id: <20250113142725.523748-6-m.sandoval@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250113142725.523748-1-m.sandoval@proxmox.com>
References: <20250113142725.523748-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.054 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist
[185.199.111.153, 185.199.108.153, 185.199.109.153, 185.199.110.153]
Subject: [pdm-devel] [PATCH proxmox-yew-comp 06/15] use any() instead of
find and is_none combination
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
Fixes:
warning: called `is_none()` after searching an `Iterator` with `find`
--> src/apt_repositories.rs:282:8
|
282 | if list.iter().find(|l| l.status != Status::Ok).is_none() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `!list.iter().any(|l| l.status != Status::Ok)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `#[warn(clippy::search_is_some)]` on by default
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/apt_repositories.rs | 2 +-
src/configuration/network_view.rs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/apt_repositories.rs b/src/apt_repositories.rs
index 365e01b..2998a5a 100644
--- a/src/apt_repositories.rs
+++ b/src/apt_repositories.rs
@@ -276,7 +276,7 @@ fn update_status_store(
)));
}
- if list.iter().find(|l| l.status != Status::Ok).is_none() {
+ if !list.iter().any(|l| l.status != Status::Ok) {
list.push(StatusLine::ok(tr!(
"All OK, you have production-ready repositories configured!"
)));
diff --git a/src/configuration/network_view.rs b/src/configuration/network_view.rs
index c56d97c..4666b64 100644
--- a/src/configuration/network_view.rs
+++ b/src/configuration/network_view.rs
@@ -97,7 +97,7 @@ impl ProxmoxNetworkView {
fn find_next_free_interface_id(prefix: &str, list: &[Interface]) -> Option<String> {
for next in 0..9999 {
let id = format!("{prefix}{next}");
- if list.iter().find(|item| item.name == id).is_none() {
+ if !list.iter().any(|item| item.name == id) {
return Some(id);
}
}
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel