From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-yew-comp 06/15] use any() instead of find and is_none combination
Date: Mon, 13 Jan 2025 15:27:16 +0100 [thread overview]
Message-ID: <20250113142725.523748-6-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20250113142725.523748-1-m.sandoval@proxmox.com>
Fixes:
warning: called `is_none()` after searching an `Iterator` with `find`
--> src/apt_repositories.rs:282:8
|
282 | if list.iter().find(|l| l.status != Status::Ok).is_none() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `!list.iter().any(|l| l.status != Status::Ok)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `#[warn(clippy::search_is_some)]` on by default
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/apt_repositories.rs | 2 +-
src/configuration/network_view.rs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/apt_repositories.rs b/src/apt_repositories.rs
index 365e01b..2998a5a 100644
--- a/src/apt_repositories.rs
+++ b/src/apt_repositories.rs
@@ -276,7 +276,7 @@ fn update_status_store(
)));
}
- if list.iter().find(|l| l.status != Status::Ok).is_none() {
+ if !list.iter().any(|l| l.status != Status::Ok) {
list.push(StatusLine::ok(tr!(
"All OK, you have production-ready repositories configured!"
)));
diff --git a/src/configuration/network_view.rs b/src/configuration/network_view.rs
index c56d97c..4666b64 100644
--- a/src/configuration/network_view.rs
+++ b/src/configuration/network_view.rs
@@ -97,7 +97,7 @@ impl ProxmoxNetworkView {
fn find_next_free_interface_id(prefix: &str, list: &[Interface]) -> Option<String> {
for next in 0..9999 {
let id = format!("{prefix}{next}");
- if list.iter().find(|item| item.name == id).is_none() {
+ if !list.iter().any(|item| item.name == id) {
return Some(id);
}
}
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-01-13 14:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 14:27 [pdm-devel] [PATCH proxmox-yew-comp 01/15] remove needless borrows Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 02/15] remove needless casts Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 03/15] apt_package_manager: use &str instead of format! Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 04/15] apt_repositories: collapse else-if blocks Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 05/15] apt_repositories: collapse match statement with if-let Maximiliano Sandoval
2025-01-13 14:27 ` Maximiliano Sandoval [this message]
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 07/15] remove unnecesary closure used with then() Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 08/15] use *= operator for assigments Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 09/15] use or_default and unwrap_or_default Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 10/15] remove redundant pattern matching Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 11/15] use std::mem::swap instead of manual swapping Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 12/15] use enumerate() instead of indexing Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 13/15] use len() instead of length comparison to zero Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 14/15] use cloned() instead of explicit clone() in closure Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 15/15] use and_then instead of map(..).flatten(..) on Option Maximiliano Sandoval
2025-01-14 8:29 ` [pdm-devel] applied: [PATCH proxmox-yew-comp 01/15] remove needless borrows Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113142725.523748-6-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox