From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id AC3401FF173
for <inbox@lore.proxmox.com>; Mon, 13 Jan 2025 15:28:22 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 7C580102E;
Mon, 13 Jan 2025 15:28:02 +0100 (CET)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Date: Mon, 13 Jan 2025 15:27:15 +0100
Message-Id: <20250113142725.523748-5-m.sandoval@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250113142725.523748-1-m.sandoval@proxmox.com>
References: <20250113142725.523748-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.054 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist
[185.199.108.153, 185.199.111.153, 185.199.109.153, 185.199.110.153]
Subject: [pdm-devel] [PATCH proxmox-yew-comp 05/15] apt_repositories:
collapse match statement with if-let
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
Fixes:
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/apt_repositories.rs:521:17
|
521 | / match selected_record {
522 | | TreeEntry::Repository {
523 | | path, index, repo, ..
524 | | } => {
... |
544 | | _ => {}
545 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
521 ~ if let TreeEntry::Repository {
522 + path, index, repo, ..
523 + } = selected_record {
524 + let param = json!({
525 + "path": path,
526 + "index": index,
527 + "enabled": !repo.enabled,
528 + });
529 + // fixme: add digest to protect against concurrent changes
530 + let url = format!("{}/repositories", props.base_url);
531 + let link = ctx.link();
532 + link.clone().spawn(async move {
533 + match crate::http_post(url, Some(param)).await {
534 + Ok(()) => {
535 + link.send_reload();
536 + }
537 + Err(err) => {
538 + link.show_error(tr!("API call failed"), err, true);
539 + }
540 + }
541 + });
542 + }
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/apt_repositories.rs | 44 ++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/src/apt_repositories.rs b/src/apt_repositories.rs
index 8e6207f..365e01b 100644
--- a/src/apt_repositories.rs
+++ b/src/apt_repositories.rs
@@ -515,30 +515,28 @@ impl LoadableComponent for ProxmoxAptRepositories {
Some(record) => record,
None => return false,
};
- match selected_record {
- TreeEntry::Repository {
- path, index, repo, ..
- } => {
- let param = json!({
- "path": path,
- "index": index,
- "enabled": !repo.enabled,
- });
- // fixme: add digest to protect against concurrent changes
- let url = format!("{}/repositories", props.base_url);
- let link = ctx.link();
- link.clone().spawn(async move {
- match crate::http_post(url, Some(param)).await {
- Ok(()) => {
- link.send_reload();
- }
- Err(err) => {
- link.show_error(tr!("API call failed"), err, true);
- }
+ if let TreeEntry::Repository {
+ path, index, repo, ..
+ } = selected_record
+ {
+ let param = json!({
+ "path": path,
+ "index": index,
+ "enabled": !repo.enabled,
+ });
+ // fixme: add digest to protect against concurrent changes
+ let url = format!("{}/repositories", props.base_url);
+ let link = ctx.link();
+ link.clone().spawn(async move {
+ match crate::http_post(url, Some(param)).await {
+ Ok(()) => {
+ link.send_reload();
}
- });
- }
- _ => {}
+ Err(err) => {
+ link.show_error(tr!("API call failed"), err, true);
+ }
+ }
+ });
}
false
}
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel