From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 485B51FF173
for <inbox@lore.proxmox.com>; Mon, 13 Jan 2025 15:27:49 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 101EEDE8;
Mon, 13 Jan 2025 15:27:31 +0100 (CET)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Date: Mon, 13 Jan 2025 15:27:12 +0100
Message-Id: <20250113142725.523748-2-m.sandoval@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250113142725.523748-1-m.sandoval@proxmox.com>
References: <20250113142725.523748-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.053 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist
[185.199.109.153, 185.199.108.153, 185.199.111.153, 185.199.110.153]
Subject: [pdm-devel] [PATCH proxmox-yew-comp 02/15] remove needless casts
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
Fixes:
warning: casting to the same type is unnecessary (`f64` -> `f64`)
--> src/rrd_graph_new.rs:514:23
|
514 | + (((t - start_time) as f64 * width) as f64) / time_span
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((t - start_time) as f64 * width)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
warning: casting float literal to `f64` is unnecessary
--> src/rrd_graph_new.rs:208:20
|
208 | while (range / (2.0 as f64).powi(l)) < 4.0 {
| ^^^^^^^^^^^^ help: try: `2.0_f64`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/rrd_graph_new.rs | 10 +++++-----
src/rrd_grid.rs | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/rrd_graph_new.rs b/src/rrd_graph_new.rs
index 2d1db13..00fa39a 100644
--- a/src/rrd_graph_new.rs
+++ b/src/rrd_graph_new.rs
@@ -179,11 +179,11 @@ fn get_grid_unit_base10(min: f64, max: f64) -> f64 {
let mut l = range.log10() as i32;
- while (range / (10.0 as f64).powi(l)) < 2.0 {
+ while (range / 10.0_f64.powi(l)) < 2.0 {
l -= 1;
}
- let mut res = (10.0 as f64).powi(l);
+ let mut res = 10.0_f64.powi(l);
let count = range / res;
@@ -205,11 +205,11 @@ fn get_grid_unit_base2(min: f64, max: f64) -> f64 {
let mut l = range.log2() as i32;
- while (range / (2.0 as f64).powi(l)) < 4.0 {
+ while (range / 2.0_f64.powi(l)) < 4.0 {
l -= 1;
}
- let mut res = (2.0 as f64).powi(l);
+ let mut res = 2.0_f64.powi(l);
let count = range / res;
@@ -511,7 +511,7 @@ impl PwtRRDGraph {
let width = (layout.width - layout.left_offset - layout.grid_border * 2) as f64;
move |t: i64| -> f64 {
(layout.left_offset + layout.grid_border) as f64
- + (((t - start_time) as f64 * width) as f64) / time_span
+ + ((t - start_time) as f64 * width) / time_span
}
};
diff --git a/src/rrd_grid.rs b/src/rrd_grid.rs
index 9ad3d7d..5432b72 100644
--- a/src/rrd_grid.rs
+++ b/src/rrd_grid.rs
@@ -45,11 +45,11 @@ impl Component for ProxmoxRRDGrid {
let cw = 800;
let width = width.max(cw);
let padding = 6;
- let mut cols = (width / cw) as usize;
+ let mut cols = width / cw;
if cols == 0 {
cols = 1;
}
- let col_width = (width as usize - 2 * padding) / cols;
+ let col_width = (width - 2 * padding) / cols;
self.cols = cols;
self.col_width = col_width - padding;
true
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel