From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A36161FF173 for ; Mon, 13 Jan 2025 15:28:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8A32BEAD; Mon, 13 Jan 2025 15:28:00 +0100 (CET) From: Maximiliano Sandoval To: pdm-devel@lists.proxmox.com Date: Mon, 13 Jan 2025 15:27:22 +0100 Message-Id: <20250113142725.523748-12-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250113142725.523748-1-m.sandoval@proxmox.com> References: <20250113142725.523748-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.110.153, 185.199.109.153, 185.199.108.153, 185.199.111.153] Subject: [pdm-devel] [PATCH proxmox-yew-comp 12/15] use enumerate() instead of indexing X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Fixes: warning: the loop variable `i` is used to index `time_data` --> src/rrd_graph_new.rs:388:14 | 388 | for i in 0..time_data.len() { | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator and enumerate() | 388 | for (i, ) in time_data.iter().enumerate() { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Maximiliano Sandoval --- src/rrd_graph_new.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/rrd_graph_new.rs b/src/rrd_graph_new.rs index 32b6126..f549c4f 100644 --- a/src/rrd_graph_new.rs +++ b/src/rrd_graph_new.rs @@ -385,10 +385,9 @@ fn compute_outline_path( ) -> String { let mut path = String::new(); let mut last_undefined = true; - for i in 0..time_data.len() { - let t = time_data[i]; + for (i, t) in time_data.iter().enumerate() { let value = *values.get(i).unwrap_or(&f64::NAN); - let x = compute_x(t); + let x = compute_x(*t); if last_undefined { if value.is_nan() { -- 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel