From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 23BD71FF18E for ; Mon, 13 Jan 2025 15:28:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CEF21183E; Mon, 13 Jan 2025 15:28:29 +0100 (CET) From: Maximiliano Sandoval To: pdm-devel@lists.proxmox.com Date: Mon, 13 Jan 2025 15:27:21 +0100 Message-Id: <20250113142725.523748-11-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250113142725.523748-1-m.sandoval@proxmox.com> References: <20250113142725.523748-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.109.153, 185.199.111.153, 185.199.108.153, 185.199.110.153] Subject: [pdm-devel] [PATCH proxmox-yew-comp 11/15] use std::mem::swap instead of manual swapping X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Fixes: warning: this looks like you are swapping `start_x` and `end_x` manually --> src/rrd_graph_new.rs:643:25 | 643 | / let t = start_x; 644 | | start_x = end_x; 645 | | end_x = t; | |__________________________________^ help: try: `std::mem::swap(&mut start_x, &mut end_x);` | = note: or maybe you should use `std::mem::replace`? = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap = note: `#[warn(clippy::manual_swap)]` on by default Signed-off-by: Maximiliano Sandoval --- src/rrd_graph_new.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/rrd_graph_new.rs b/src/rrd_graph_new.rs index 0b08e08..32b6126 100644 --- a/src/rrd_graph_new.rs +++ b/src/rrd_graph_new.rs @@ -640,9 +640,7 @@ impl PwtRRDGraph { let mut end_x = compute_x(*end_data); if start_x > end_x { - let t = start_x; - start_x = end_x; - end_x = t; + std::mem::swap(&mut start_x, &mut end_x); } let start_y = compute_y(min_data); -- 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel