From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8330A1FF173 for ; Mon, 13 Jan 2025 15:28:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C11A1569; Mon, 13 Jan 2025 15:28:29 +0100 (CET) From: Maximiliano Sandoval To: pdm-devel@lists.proxmox.com Date: Mon, 13 Jan 2025 15:27:20 +0100 Message-Id: <20250113142725.523748-10-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250113142725.523748-1-m.sandoval@proxmox.com> References: <20250113142725.523748-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.110.153, 185.199.108.153, 185.199.111.153, 185.199.109.153] Subject: [pdm-devel] [PATCH proxmox-yew-comp 10/15] remove redundant pattern matching X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Fixes: warning: redundant pattern matching, consider using `is_err()` --> src/rrd_timeframe_selector.rs:116:20 | 116 | if let Err(_) = store.set_item("ProxmoxRRDTimeframe", &timeframe_str) { | -------^^^^^^-------------------------------------------------------- help: try: `if store.set_item("ProxmoxRRDTimeframe", &timeframe_str).is_err()` | = note: this will change drop order of the result, as well as all temporaries = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default Signed-off-by: Maximiliano Sandoval --- src/rrd_timeframe_selector.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/rrd_timeframe_selector.rs b/src/rrd_timeframe_selector.rs index 00f22ab..a027046 100644 --- a/src/rrd_timeframe_selector.rs +++ b/src/rrd_timeframe_selector.rs @@ -113,7 +113,10 @@ impl RRDTimeframe { pub fn store(&self) { if let Some(store) = local_storage() { let timeframe_str = self.serialize(); - if let Err(_) = store.set_item("ProxmoxRRDTimeframe", &timeframe_str) { + if store + .set_item("ProxmoxRRDTimeframe", &timeframe_str) + .is_err() + { log::error!("RRDTimeframe::store - set_item failed"); } else { emit_rrd_timeframe_changed_event(); -- 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel