public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-yew-comp 10/15] remove redundant pattern matching
Date: Mon, 13 Jan 2025 15:27:20 +0100	[thread overview]
Message-ID: <20250113142725.523748-10-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20250113142725.523748-1-m.sandoval@proxmox.com>

Fixes:

warning: redundant pattern matching, consider using `is_err()`
   --> src/rrd_timeframe_selector.rs:116:20
    |
116 |             if let Err(_) = store.set_item("ProxmoxRRDTimeframe", &timeframe_str) {
    |             -------^^^^^^-------------------------------------------------------- help: try: `if store.set_item("ProxmoxRRDTimeframe", &timeframe_str).is_err()`
    |
    = note: this will change drop order of the result, as well as all temporaries
    = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/rrd_timeframe_selector.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/rrd_timeframe_selector.rs b/src/rrd_timeframe_selector.rs
index 00f22ab..a027046 100644
--- a/src/rrd_timeframe_selector.rs
+++ b/src/rrd_timeframe_selector.rs
@@ -113,7 +113,10 @@ impl RRDTimeframe {
     pub fn store(&self) {
         if let Some(store) = local_storage() {
             let timeframe_str = self.serialize();
-            if let Err(_) = store.set_item("ProxmoxRRDTimeframe", &timeframe_str) {
+            if store
+                .set_item("ProxmoxRRDTimeframe", &timeframe_str)
+                .is_err()
+            {
                 log::error!("RRDTimeframe::store - set_item failed");
             } else {
                 emit_rrd_timeframe_changed_event();
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-01-13 14:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13 14:27 [pdm-devel] [PATCH proxmox-yew-comp 01/15] remove needless borrows Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 02/15] remove needless casts Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 03/15] apt_package_manager: use &str instead of format! Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 04/15] apt_repositories: collapse else-if blocks Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 05/15] apt_repositories: collapse match statement with if-let Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 06/15] use any() instead of find and is_none combination Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 07/15] remove unnecesary closure used with then() Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 08/15] use *= operator for assigments Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 09/15] use or_default and unwrap_or_default Maximiliano Sandoval
2025-01-13 14:27 ` Maximiliano Sandoval [this message]
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 11/15] use std::mem::swap instead of manual swapping Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 12/15] use enumerate() instead of indexing Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 13/15] use len() instead of length comparison to zero Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 14/15] use cloned() instead of explicit clone() in closure Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 15/15] use and_then instead of map(..).flatten(..) on Option Maximiliano Sandoval
2025-01-14  8:29 ` [pdm-devel] applied: [PATCH proxmox-yew-comp 01/15] remove needless borrows Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250113142725.523748-10-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal