public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-yew-comp 01/15] remove needless borrows
Date: Mon, 13 Jan 2025 15:27:11 +0100	[thread overview]
Message-ID: <20250113142725.523748-1-m.sandoval@proxmox.com> (raw)

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/apt_package_manager.rs        | 2 +-
 src/apt_repositories.rs           | 6 +++---
 src/configuration/network_edit.rs | 2 +-
 src/configuration/network_view.rs | 2 +-
 src/form/mod.rs                   | 2 +-
 src/rrd_graph_new.rs              | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/apt_package_manager.rs b/src/apt_package_manager.rs
index 6e0d677..5171d81 100644
--- a/src/apt_package_manager.rs
+++ b/src/apt_package_manager.rs
@@ -237,7 +237,7 @@ impl LoadableComponent for ProxmoxAptPackageManager {
     ) -> Option<Html> {
         match view_state {
             ViewState::ShowChangelog(package) => {
-                Some(self.create_show_changelog_dialog(ctx, &package))
+                Some(self.create_show_changelog_dialog(ctx, package))
             }
         }
     }
diff --git a/src/apt_repositories.rs b/src/apt_repositories.rs
index c92665e..bf308bd 100644
--- a/src/apt_repositories.rs
+++ b/src/apt_repositories.rs
@@ -213,7 +213,7 @@ fn update_status_store(
                 if check_mixed_suites
                     && repo.enabled
                     && repo.types.contains(&APTRepositoryPackageType::Deb)
-                    && controlled_origin.contains(&(&path, index))
+                    && controlled_origin.contains(&(path, index))
                 {
                     mixed_suites = true;
                 }
@@ -474,7 +474,7 @@ impl LoadableComponent for ProxmoxAptRepositories {
                     update_status_store(
                         props.product,
                         &self.status_store,
-                        &config,
+                        config,
                         &self.standard_repos,
                         active_subscription,
                     );
@@ -503,7 +503,7 @@ impl LoadableComponent for ProxmoxAptRepositories {
                 self.standard_repos = standard_repos.clone();
 
                 self.validate_standard_repo = ValidateFn::new(move |(repo, _): &(String, _)| {
-                    let (_, _, enabled) = standard_repo_info(&standard_repos, &repo);
+                    let (_, _, enabled) = standard_repo_info(&standard_repos, repo);
                     if enabled {
                         Err(Error::msg(tr!("Already configured")))
                     } else {
diff --git a/src/configuration/network_edit.rs b/src/configuration/network_edit.rs
index 5629da9..010dc30 100644
--- a/src/configuration/network_edit.rs
+++ b/src/configuration/network_edit.rs
@@ -61,7 +61,7 @@ async fn create_item(
         }
     }
 
-    data["type"] = serde_json::to_value(&interface_type).unwrap();
+    data["type"] = serde_json::to_value(interface_type).unwrap();
 
     crate::http_post("/nodes/localhost/network", Some(data)).await
 }
diff --git a/src/configuration/network_view.rs b/src/configuration/network_view.rs
index 5cc0d68..c56d97c 100644
--- a/src/configuration/network_view.rs
+++ b/src/configuration/network_view.rs
@@ -36,7 +36,7 @@ async fn load_interfaces() -> Result<(Vec<Interface>, String), Error> {
 async fn delete_interface(key: Key) -> Result<(), Error> {
     let url = format!(
         "/nodes/localhost/network/{}",
-        percent_encode_component(&*key)
+        percent_encode_component(&key)
     );
     crate::http_delete(&url, None).await?;
     Ok(())
diff --git a/src/form/mod.rs b/src/form/mod.rs
index 9661c28..0b9d8a9 100644
--- a/src/form/mod.rs
+++ b/src/form/mod.rs
@@ -16,7 +16,7 @@ fn format_property(name: &str, part: &str) -> String {
 /// to expose a property to the UI, simply add a hidden field to the form.
 pub fn flatten_property_string(data: &mut Value, name: &str, schema: &'static Schema) {
     if let Some(prop_str) = data[name].as_str() {
-        if let Ok(Value::Object(map)) = schema.parse_property_string(&prop_str) {
+        if let Ok(Value::Object(map)) = schema.parse_property_string(prop_str) {
             for (part, v) in map {
                 data[format_property(name, &part)] = v;
             }
diff --git a/src/rrd_graph_new.rs b/src/rrd_graph_new.rs
index 26a19b6..2d1db13 100644
--- a/src/rrd_graph_new.rs
+++ b/src/rrd_graph_new.rs
@@ -488,7 +488,7 @@ impl PwtRRDGraph {
                 &serie1_data[serie1_start..serie1_end],
             )
         } else {
-            (&time_data, &serie0_data, &serie1_data)
+            (time_data, serie0_data, serie1_data)
         }
     }
 
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-01-13 14:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13 14:27 Maximiliano Sandoval [this message]
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 02/15] remove needless casts Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 03/15] apt_package_manager: use &str instead of format! Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 04/15] apt_repositories: collapse else-if blocks Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 05/15] apt_repositories: collapse match statement with if-let Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 06/15] use any() instead of find and is_none combination Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 07/15] remove unnecesary closure used with then() Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 08/15] use *= operator for assigments Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 09/15] use or_default and unwrap_or_default Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 10/15] remove redundant pattern matching Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 11/15] use std::mem::swap instead of manual swapping Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 12/15] use enumerate() instead of indexing Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 13/15] use len() instead of length comparison to zero Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 14/15] use cloned() instead of explicit clone() in closure Maximiliano Sandoval
2025-01-13 14:27 ` [pdm-devel] [PATCH proxmox-yew-comp 15/15] use and_then instead of map(..).flatten(..) on Option Maximiliano Sandoval
2025-01-14  8:29 ` [pdm-devel] applied: [PATCH proxmox-yew-comp 01/15] remove needless borrows Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250113142725.523748-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal