From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C979A1FF173 for ; Mon, 13 Jan 2025 13:08:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BCEB22DA79; Mon, 13 Jan 2025 13:08:35 +0100 (CET) From: Maximiliano Sandoval To: pdm-devel@lists.proxmox.com Date: Mon, 13 Jan 2025 13:08:31 +0100 Message-Id: <20250113120831.299244-4-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250113120831.299244-1-m.sandoval@proxmox.com> References: <20250113120831.299244-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.109.153, 185.199.108.153, 185.199.111.153, 185.199.110.153] Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 4/4] resources: Remove unnecessary closure X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" warning: unnecessary closure used to substitute value for `Option::None` --> server/src/api/resources.rs:322:21 | 322 | let timeframe = timeframe.unwrap_or_else(|| RrdTimeframe::Day); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default help: use `unwrap_or` instead | 322 | let timeframe = timeframe.unwrap_or(RrdTimeframe::Day); Signed-off-by: Maximiliano Sandoval --- server/src/api/resources.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs index f6438c6..453d9e8 100644 --- a/server/src/api/resources.rs +++ b/server/src/api/resources.rs @@ -319,7 +319,7 @@ pub async fn get_subscription_status( async fn get_top_entities(timeframe: Option) -> Result { let (remotes_config, _) = pdm_config::remotes::config()?; - let timeframe = timeframe.unwrap_or_else(|| RrdTimeframe::Day); + let timeframe = timeframe.unwrap_or(RrdTimeframe::Day); let res = crate::metric_collection::calculate_top(&remotes_config.sections, timeframe, 10); Ok(res) } -- 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel