public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager] ui: pve storage selector: fix the displayed values
Date: Tue,  7 Jan 2025 14:23:03 +0100	[thread overview]
Message-ID: <20250107132303.2447962-1-d.csapak@proxmox.com> (raw)

we want to show 'available' and 'capacity' (indicated by the column
headers), but showed 'used' and 'available' respectively.

Fix this by using the correct values from the struct.

While at it, rename the intermediated variables to match what they are.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/widget/pve_storage_selector.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ui/src/widget/pve_storage_selector.rs b/ui/src/widget/pve_storage_selector.rs
index 188acc6..488175a 100644
--- a/ui/src/widget/pve_storage_selector.rs
+++ b/ui/src/widget/pve_storage_selector.rs
@@ -209,15 +209,15 @@ fn columns() -> Rc<Vec<DataTableHeader<StorageInfo>>> {
             .into(),
         DataTableColumn::new(tr!("Avail"))
             .get_property_owned(|entry: &StorageInfo| entry.used.unwrap_or_default())
-            .render(|entry: &StorageInfo| match entry.used {
-                Some(used) => html! {format!("{:.2}", HumanByte::new_decimal(used as f64))},
+            .render(|entry: &StorageInfo| match entry.avail {
+                Some(avail) => html! {format!("{:.2}", HumanByte::new_decimal(avail as f64))},
                 None => html! {"-"},
             })
             .into(),
         DataTableColumn::new(tr!("Capacity"))
             .get_property_owned(|entry: &StorageInfo| entry.avail.unwrap_or_default())
-            .render(|entry: &StorageInfo| match entry.avail {
-                Some(used) => html! { format!("{:.2}", HumanByte::new_decimal(used as f64))},
+            .render(|entry: &StorageInfo| match entry.total {
+                Some(total) => html! { format!("{:.2}", HumanByte::new_decimal(total as f64))},
                 None => html! {"-"},
             })
             .into(),
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-01-07 13:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07 13:23 Dominik Csapak [this message]
2025-01-08 12:09 ` [pdm-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107132303.2447962-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal