* [pdm-devel] [PATCH datacenter-manager 1/2] ui: disable 'my settings' menu item @ 2024-12-19 9:33 Dominik Csapak 2024-12-19 9:33 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: disable documentation button Dominik Csapak 2024-12-19 11:05 ` [pdm-devel] applied: [PATCH datacenter-manager 1/2] ui: disable 'my settings' menu item Thomas Lamprecht 0 siblings, 2 replies; 5+ messages in thread From: Dominik Csapak @ 2024-12-19 9:33 UTC (permalink / raw) To: pdm-devel not yet implemented Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> --- ui/src/top_nav_bar.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/src/top_nav_bar.rs b/ui/src/top_nav_bar.rs index 9d9d59d..3a9f16c 100644 --- a/ui/src/top_nav_bar.rs +++ b/ui/src/top_nav_bar.rs @@ -142,7 +142,8 @@ impl Component for PdmTopNavBar { .map(|cb| Callback::from(move |_event: MenuEvent| cb.emit(()))); let menu = Menu::new() - .with_item(MenuItem::new(tr!("My Settings")).icon_class("fa fa-gear")) + // FIXME: implement + //.with_item(MenuItem::new(tr!("My Settings")).icon_class("fa fa-gear")) .with_item( MenuItem::new(tr!("Language")) .icon_class("fa fa-language") -- 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [pdm-devel] [PATCH datacenter-manager 2/2] ui: disable documentation button 2024-12-19 9:33 [pdm-devel] [PATCH datacenter-manager 1/2] ui: disable 'my settings' menu item Dominik Csapak @ 2024-12-19 9:33 ` Dominik Csapak 2024-12-19 9:58 ` Maximiliano Sandoval 2024-12-19 11:05 ` [pdm-devel] applied: [PATCH datacenter-manager 1/2] ui: disable 'my settings' menu item Thomas Lamprecht 1 sibling, 1 reply; 5+ messages in thread From: Dominik Csapak @ 2024-12-19 9:33 UTC (permalink / raw) To: pdm-devel and add a 'coming soon' tooltip. Re-enable when we ship documentation. Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> --- ui/src/top_nav_bar.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/ui/src/top_nav_bar.rs b/ui/src/top_nav_bar.rs index 3a9f16c..70ba524 100644 --- a/ui/src/top_nav_bar.rs +++ b/ui/src/top_nav_bar.rs @@ -10,7 +10,7 @@ use yew::html::{IntoEventCallback, IntoPropValue}; use yew::virtual_dom::{VComp, VNode}; use pwt::state::{Loader, Theme, ThemeObserver}; -use pwt::widget::{Container, Row, ThemeModeSelector}; +use pwt::widget::{Button, Container, Row, ThemeModeSelector, Tooltip}; use proxmox_yew_comp::common_api_types::TaskListItem; use proxmox_yew_comp::RunningTasksButton; @@ -171,7 +171,17 @@ impl Component for PdmTopNavBar { .class("pwt-align-items-center") .gap(2) .with_child(ThemeModeSelector::new().class("pwt-scheme-neutral-alt")) - .with_child(HelpButton::new().class("pwt-scheme-neutral")); + // FIXME: implement + //.with_child(HelpButton::new().class("pwt-scheme-neutral")) + .with_child( + Tooltip::new( + Button::new(tr!("Documentation")) + .icon_class("fa fa-book") + .disabled(true) + .class(ColorScheme::Neutral), + ) + .tip(tr!("Coming soon")), + ); if let Some(username) = &props.username { button_group.add_child( -- 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pdm-devel] [PATCH datacenter-manager 2/2] ui: disable documentation button 2024-12-19 9:33 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: disable documentation button Dominik Csapak @ 2024-12-19 9:58 ` Maximiliano Sandoval 2024-12-19 10:17 ` Thomas Lamprecht 0 siblings, 1 reply; 5+ messages in thread From: Maximiliano Sandoval @ 2024-12-19 9:58 UTC (permalink / raw) To: Proxmox Datacenter Manager development discussion Dominik Csapak <d.csapak@proxmox.com> writes: > and add a 'coming soon' tooltip. Re-enable when we ship documentation. What is the rationale for having a placeholder element? Imho placeholder buttons/elements do not help in user-facing interfaces. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pdm-devel] [PATCH datacenter-manager 2/2] ui: disable documentation button 2024-12-19 9:58 ` Maximiliano Sandoval @ 2024-12-19 10:17 ` Thomas Lamprecht 0 siblings, 0 replies; 5+ messages in thread From: Thomas Lamprecht @ 2024-12-19 10:17 UTC (permalink / raw) To: Proxmox Datacenter Manager development discussion, Maximiliano Sandoval Am 19.12.24 um 10:58 schrieb Maximiliano Sandoval: > > Dominik Csapak <d.csapak@proxmox.com> writes: > >> and add a 'coming soon' tooltip. Re-enable when we ship documentation. > > What is the rationale for having a placeholder element? Imho placeholder > buttons/elements do not help in user-facing interfaces. > To convey that documentation really does not exist yet, not that user search for it and think they just cannot find it. It was my idea, Dominik just removed it at first, but I'm not married to the idea, so fine by me to drop it if you both really think it's better that way. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [pdm-devel] applied: [PATCH datacenter-manager 1/2] ui: disable 'my settings' menu item 2024-12-19 9:33 [pdm-devel] [PATCH datacenter-manager 1/2] ui: disable 'my settings' menu item Dominik Csapak 2024-12-19 9:33 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: disable documentation button Dominik Csapak @ 2024-12-19 11:05 ` Thomas Lamprecht 1 sibling, 0 replies; 5+ messages in thread From: Thomas Lamprecht @ 2024-12-19 11:05 UTC (permalink / raw) To: Proxmox Datacenter Manager development discussion, Dominik Csapak Am 19.12.24 um 10:33 schrieb Dominik Csapak: > not yet implemented > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > ui/src/top_nav_bar.rs | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied both patches as is for now, we can still fine-tune this if users are getting confused by the disabled doc button, thanks! _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-19 11:05 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-12-19 9:33 [pdm-devel] [PATCH datacenter-manager 1/2] ui: disable 'my settings' menu item Dominik Csapak 2024-12-19 9:33 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: disable documentation button Dominik Csapak 2024-12-19 9:58 ` Maximiliano Sandoval 2024-12-19 10:17 ` Thomas Lamprecht 2024-12-19 11:05 ` [pdm-devel] applied: [PATCH datacenter-manager 1/2] ui: disable 'my settings' menu item Thomas Lamprecht
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox