From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 20CBA1FF15C
for <inbox@lore.proxmox.com>; Fri, 18 Apr 2025 08:12:13 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 69CD5369DD;
Fri, 18 Apr 2025 08:12:10 +0200 (CEST)
Message-ID: <1e09b216-3616-432e-9022-8cda036a612b@proxmox.com>
Date: Fri, 18 Apr 2025 08:12:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
References: <20250416113151.2484200-1-d.csapak@proxmox.com>
<cd06f13a-08dc-4247-9bfe-3c2c4da2faaf@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <cd06f13a-08dc-4247-9bfe-3c2c4da2faaf@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [resources.rs]
Subject: Re: [pdm-devel] [PATCH datacenter-manager] server: api: resources:
handle template in status count
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
On 4/17/25 17:38, Thomas Lamprecht wrote:
> Seems simple enough, but the existences of the FIXME comments warrant
> and actual commit message, i.e. why wasn't this done earlier already
> if it's so simple? And FWIW, a short message would not hurt in any way.
>
ah yes, sorry.
For the longest time we did not get the info about templates from the api because
the pve return description for that was missing. And after we added
that, nobody updated this code to handle the new fields.
I'll send a v2 with that explanation in the commit message
> Am 16.04.25 um 13:31 schrieb Dominik Csapak:
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> server/src/api/resources.rs | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
>> index 453d9e8..ddcee7e 100644
>> --- a/server/src/api/resources.rs
>> +++ b/server/src/api/resources.rs
>> @@ -191,14 +191,14 @@ pub async fn get_status(
>> _ => counts.storages.unknown += 1,
>> },
>> Resource::PveQemu(r) => match r.status.as_str() {
>> + _ if r.template => counts.qemu.template += 1,
>> "running" => counts.qemu.running += 1,
>> - // FIXME: handle templates
>> "stopped" => counts.qemu.stopped += 1,
>> _ => counts.qemu.unknown += 1,
>> },
>> Resource::PveLxc(r) => match r.status.as_str() {
>> + _ if r.template => counts.lxc.template += 1,
>> "running" => counts.lxc.running += 1,
>> - // FIXME: handle templates
>> "stopped" => counts.lxc.stopped += 1,
>> _ => counts.lxc.unknown += 1,
>> },
>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel