Re: [RFC PATCH datacenter-manager 1/4] server: connection: multi client: use correct client error for retrying

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 03/06/2026 13:59, Dominik Csapak wrote:
> so of the methods we use in pve/pbs, only POST is not idempotent per
> the spec, but e.g. we can use 'PUT' for making non-idempotent changes to a vm config (for example adding a disk to a VM, this will create
> a disk and make any in the same slot unused)
>
> I'm not super sure if we can get an client error here in a way
> that would process the request with side effects on pve side and still
> trigger a  retry on the pdm side, so I doubt this will make a difference
> in practice. Still wanted to mention it.

The digest-check should catch the repeated call though, as long as we
send that along, we're fine (besides maybe 1. add cfg entry, connection
fails on return but PVE processed it 2. another request deletes that cfg
immediately again 3. second retried add hits PVE and digest is again the
same; but tbh., that's an rather theoretical edge case and would require
multiple independent automation stacks interfering with each other, which
leads to odd effects in any case.