From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 676AF1FF0EC for ; Sat, 07 Nov 2026 23:11:43 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F012D215DA; Sat, 07 Nov 2026 23:11:42 +0100 (CET) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Christoph Heiss Subject: applied: [PATCH datacenter-manager/proxmox v2 0/7] auto-install: add support for VLAN and bond configurations Date: Sat, 7 Nov 2026 23:10:53 +0100 Message-ID: <179408929293.3054669.10671586917541607291.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261106131419.822904-1-c.heiss@proxmox.com> References: <20261106131419.822904-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794089497234 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.151 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RUZGV6OVA5FYJNWP7XGMWA2FZAGS6NVO X-Message-ID-Hash: RUZGV6OVA5FYJNWP7XGMWA2FZAGS6NVO X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 06 Nov 2026 14:14:11 +0100, Christoph Heiss wrote: > Prerequisites: [0] for the installer site. > > This adds a new advanced section in the "Network" tab of the prepared > answer add/edit dialog. > > With this, the user can the VLAN tag and/or bonding for newly installed > system. > Bond member selection uses udev filters, to provide a way to dynamically > select network interfaces for target systems. > > [...] Applied, thanks! I folded a few changes into your patches see trailer for details, the relevant ones: - patches 1 to 3 are squashed into one commit, as they only build together, which also initializes the new fields in the add wizard. - backend: use the bond types from proxmox-network-types, make bond-enabled optional, so that API clients not sending it keep working, take a VLAN tag only with a static network configuration, as with DHCP the installer uses the VLAN of its installation environment, require a member filter for bonding and check the options before saving. - UI: keep the serialized names for the filesystem types. Their Display implementation returns the installer's labels, which the form cannot parse back, so saving an answer with XFS, ZFS or BTRFS selected fell back to ext4. - UI: disable the network device filter with bonding, as the installer ignores it then, require the member filter and a used hash policy, show 802.3ad as LACP, and say why the VLAN tag is disabled with DHCP. On top, as separate follow up commits: - only send answers the installer can use: an installer reporting an older answer fetch schema than the answer needs gets an error naming the required version, and the installation gets a new status, so that the list shows which answer matched but was not sent. - generate answer tokens only after all checks passed, so that a refused request no longer leaves an unused enabled token behind. - describe the bond and VLAN options in the docs. - bump proxmox-installer-types to 0.3.1 and proxmox-network-types to 1.2.1. In proxmox, I added tests for the names of the bond modes and hash policies, and installer-types now shows the MAC addresses in its bond errors in lowercase, like the installers and `ip link` do. [datacenter-manager] applied to git/proxmox-datacenter-manager.git (master) [1/5] config: auto-install: add new options for configuring vlan and bond commit: 75e67f844b21f924b9e2c9ec5eb4f70ae1fd580e [2/5] api-types: auto-installer: add new options for configuring vlan and bond commit: 75e67f844b21f924b9e2c9ec5eb4f70ae1fd580e [3/5] api: auto-installer: wire up new vlan and bond network options commit: 75e67f844b21f924b9e2c9ec5eb4f70ae1fd580e [4/5] ui: auto-installer: use .to_string() instead of manual serde variant commit: e1dae047d10c40e5660a6aa0b1676a33cbd45c02 [5/5] ui: auto-installer: add vlan and bond config as advanced options commit: 9f02124119b6f807d42e15bbcb447224ca007443 [proxmox] applied to git/proxmox.git (master) [1/2] installer-types: derive Display for RebootMode and FilterMatch commit: 50ca2db5d5f17bc07859ba666415c7ad6a9eb4a8 [2/2] network-types: derive Display and FromStr for network bond types commit: f7d3035fa42374d419bc56c4be941ea4f2570b7c