public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager 2/3] ui: d/rules: use thin instead of fat LTO
Date: Tue, 07 Jul 2026 16:05:57 +0200	[thread overview]
Message-ID: <1783433095.x62omid41h.astroid@yuna.none> (raw)
In-Reply-To: <20260706114822.2751086-3-d.csapak@proxmox.com>

On July 6, 2026 1:44 pm, Dominik Csapak wrote:
> fat LTO merges all LLVM modules into a single unit for optimizing.
> Changing this to thin LTO increases the uncompressed binary size by 1.59
> MiB (+11%) (compressed +192KiB/+4.6%) but save us ~160s (-40%) of (wall)
> build time during a 'make deb'.

but what are the effects on runtime performance? the same question also
applies to the next patch, a single codegen unit increases the amount of
optimizations the compiler can do..

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/debian/rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui/debian/rules b/ui/debian/rules
> index b3b3b078..8ffa868a 100755
> --- a/ui/debian/rules
> +++ b/ui/debian/rules
> @@ -28,7 +28,7 @@ endif
>  
>  	$(CARGO) prepare-debian $(CURDIR)/debian/cargo_registry --link-from-system
>  	sed -e 's/^debug = true$$/debug = false/g' debian/cargo_home/config.toml
> -	echo "\nlto=\"fat\"" >> debian/cargo_home/config.toml
> +	echo "\nlto=\"thin\"" >> debian/cargo_home/config.toml
>  	echo "\nopt-level=\"s\"" >> debian/cargo_home/config.toml
>  	echo "\ncodegen-units=1" >> debian/cargo_home/config.toml
>  	# patch cargo_home config to use lld with wasm, otherwise the build fails
> -- 
> 2.47.3
> 
> 
> 
> 
> 
> 




  reply	other threads:[~2026-07-07 14:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 11:44 [PATCH datacenter-manager 0/3] ui: reduce compilation time for relase builds Dominik Csapak
2026-07-06 11:44 ` [PATCH datacenter-manager 1/3] ui: d/rules: don't generate debuginfo for the UI Dominik Csapak
2026-07-07 14:18   ` Fabian Grünbichler
2026-07-06 11:44 ` [PATCH datacenter-manager 2/3] ui: d/rules: use thin instead of fat LTO Dominik Csapak
2026-07-07 14:05   ` Fabian Grünbichler [this message]
2026-07-07 14:10     ` Dominik Csapak
2026-07-07 14:51       ` Fabian Grünbichler
2026-07-07 21:53     ` Thomas Lamprecht
2026-07-08  7:11       ` Fabian Grünbichler
2026-07-08  8:44         ` Robert Obkircher
2026-07-08  9:38           ` Fabian Grünbichler
2026-07-06 11:44 ` [PATCH datacenter-manager 3/3] ui: d/rules: don't limit compilation to 1 codgen-unit Dominik Csapak
2026-07-08 10:27 ` [PATCH datacenter-manager 0/3] ui: reduce compilation time for relase builds Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1783433095.x62omid41h.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal