From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E891B1FF146 for ; Tue, 26 May 2026 11:08:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16C6C17273; Tue, 26 May 2026 11:08:41 +0200 (CEST) Date: Tue, 26 May 2026 11:08:05 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn To: pdm-devel@lists.proxmox.com, Shannon Sterz References: <20260522144633.475938-1-s.sterz@proxmox.com> In-Reply-To: <20260522144633.475938-1-s.sterz@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1779786372.iogkid8ktf.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779786463938 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JOO4YOU2KPDXAX7XRSAWIEC5OC3YUQIM X-Message-ID-Hash: JOO4YOU2KPDXAX7XRSAWIEC5OC3YUQIM X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On May 22, 2026 4:46 pm, Shannon Sterz wrote: > to avoid users not setting this value themselves, as otherwise > "host.example.com" would be set as default fqdn for an answer file > config. >=20 > Signed-off-by: Shannon Sterz > --- > ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs = b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs > index f1b443e..64d746f 100644 > --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs > +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs > @@ -55,7 +55,7 @@ impl AddAnswerWizardProperties { > target_filter: BTreeMap::new(), > // global options > country: "at".to_owned(), > - fqdn: "host.example.com".to_owned(), > + fqdn: String::new(), this looks okay to me, though I wonder whether it wouldn't be better to either default to > use_dhcp_fqdn: false, this, or use the placeholder with the template vars as default value but do not accept it as valid? > keyboard: answer::KeyboardLayout::default(), > mailto: String::new(), > --=20 > 2.47.3 >=20 >=20 >=20 >=20 >=20 >=20