From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Lukas Wagner <l.wagner@proxmox.com>
Subject: applied: [PATCH datacenter-manager] namespaced-cache: avoid double path construction and key verification
Date: Tue, 19 May 2026 23:33:31 +0200 [thread overview]
Message-ID: <177922641079.2881509.12207936448148078680.b4-ty@b4> (raw)
In-Reply-To: <20260519114915.249323-1-l.wagner@proxmox.com>
On Tue, 19 May 2026 13:49:15 +0200, Lukas Wagner wrote:
> Instead of calling set_impl from set_if_newer_impl, we now pull out
> common parts into another function, set_at_path. This ensures that some
> of work at the start of the set_impl and set_if_newer_impl is not done
> twice (key verification, path construction).
>
> Also, while at it, add a brief comment with regards to why the .unwrap()
> is safe when accessing the parent directory of the cache file path.
>
> [...]
Applied, thanks!
[1/1] namespaced-cache: avoid double path construction and key verification
commit: fbc66cff24d252854c44f8f1c2a3ac93eec53ef1
prev parent reply other threads:[~2026-05-19 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 11:49 [PATCH datacenter-manager] namespaced-cache: avoid double path construction and key verification Lukas Wagner
2026-05-19 21:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177922641079.2881509.12207936448148078680.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox